From 84f2afb4ede32a68f2387f3dc2f9d9352b89b8fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 18:23:07 +0200 Subject: [PATCH 1/7] Add a required job checker as an action (1/2) --- .github/checkgroup.yml | 38 ++++++++++++++++-------- .github/workflows/probot-check-group.yml | 15 ++++++++++ 2 files changed, 41 insertions(+), 12 deletions(-) create mode 100644 .github/workflows/probot-check-group.yml diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 4b67bc076b32d..c6518262c440a 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -6,15 +6,6 @@ subprojects: checks: - "test-on-tpus" - - id: "CI: Azure" - paths: - - ".azure/**" - checks: - - "pytorch-lightning (GPUs)" - - "pytorch-lightning (GPUs) (testing PyTorch - stable)" - - "pytorch-lightning (HPUs)" - - "pytorch-lightning (IPUs)" - - id: "pytorch_lightning" paths: # all examples don't need to be added because they aren't used in CI, but these are @@ -60,6 +51,26 @@ subprojects: - "slow (windows-2022, 3.7, 1.11)" - "test-on-tpus" + - id: "pytorch_lightning: Azure GPU" + paths: + - ".azure/gpu-tests.yml" + checks: + - "pytorch-lightning (GPUs)" + - "pytorch-lightning (GPUs) (testing PyTorch - stable)" + + - id: "pytorch_lightning: Azure HPU" + paths: + - ".azure/hpu-tests.yml" + checks: + - "pytorch-lightning (HPUs)" + - "pytorch-lightning (IPUs)" + + - id: "pytorch_lightning: Azure IPU" + paths: + - ".azure/ipu-tests.yml" + checks: + - "pytorch-lightning (IPUs)" + - id: "pytorch_lightning: Docs" paths: - "docs/source-pytorch/**" @@ -73,7 +84,6 @@ subprojects: - id: "pytorch_lightning: Docker" paths: - "dockers/**" - - "!dockers/README.md" - "requirements.txt" - "requirements/*.txt" - "requirements/pytorch/*" @@ -108,12 +118,10 @@ subprojects: - id: "lightning_app" paths: - - ".azure/app-cloud-e2e.yml" - "requirements/app/**" - "src/lightning_app/**" - "tests/tests_app/**" - "tests/tests_app_examples/**" - - "tests/tests_clusters/**" # the examples are used in the app CI - "examples/app_*" checks: @@ -127,6 +135,12 @@ subprojects: - "pytest (windows-2022, 3.8, latest)" - "pytest (windows-2022, 3.8, oldest)" + - id: "lightning_app: Azure" + paths: + - ".azure/app-cloud-e2e.yml" + checks: + - "App.cloud-e2e" + - id: "lightning_app: Docs" paths: - "docs/source-app/**" diff --git a/.github/workflows/probot-check-group.yml b/.github/workflows/probot-check-group.yml new file mode 100644 index 0000000000000..1b37e19c819b6 --- /dev/null +++ b/.github/workflows/probot-check-group.yml @@ -0,0 +1,15 @@ +name: Probot + +on: + check_run: {} + pull_request: {} + issue_comment: {types: [created]} + +jobs: + required-jobs: + runs-on: ubuntu-latest + if: github.event_name != 'issue_comment' || contains(github.event.comment.body, '@probot pls') + steps: + - uses: carmocca/probot@v2 + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From bfd1145e938523c8c48d9dffc277159193e560ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 18:34:12 +0200 Subject: [PATCH 2/7] Fix app cloud job names --- .github/checkgroup.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index c6518262c440a..005d111f4f35a 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -125,7 +125,9 @@ subprojects: # the examples are used in the app CI - "examples/app_*" checks: - - "App.cloud-e2e" + - 'App.cloud-e2e (App_cloud_e2e_testing App: template_streamlit_ui)' + - 'App.cloud-e2e (App_cloud_e2e_testing App: boring_app)' + - 'App.cloud-e2e (App_cloud_e2e_testing App: v0_app)' - "doctest (app)" - "make-docs (app)" - "pytest (macOS-11, 3.8, latest)" @@ -139,7 +141,9 @@ subprojects: paths: - ".azure/app-cloud-e2e.yml" checks: - - "App.cloud-e2e" + - 'App.cloud-e2e (App_cloud_e2e_testing App: template_streamlit_ui)' + - 'App.cloud-e2e (App_cloud_e2e_testing App: boring_app)' + - 'App.cloud-e2e (App_cloud_e2e_testing App: v0_app)' - id: "lightning_app: Docs" paths: From ffead3ff1edd14bc36cd060af29d70e78cbd07ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 18:55:27 +0200 Subject: [PATCH 3/7] Fix app jobs --- .github/checkgroup.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 005d111f4f35a..21c2cb9819ef8 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -43,7 +43,6 @@ subprojects: - "mypy" - "PR Gatekeeper (pytorch)" - "pytorch-lightning (GPUs)" - - "pytorch-lightning (GPUs) (testing PyTorch - stable)" - "pytorch-lightning (HPUs)" - "pytorch-lightning (IPUs)" - "slow (macOS-11, 3.7, 1.11)" @@ -56,7 +55,6 @@ subprojects: - ".azure/gpu-tests.yml" checks: - "pytorch-lightning (GPUs)" - - "pytorch-lightning (GPUs) (testing PyTorch - stable)" - id: "pytorch_lightning: Azure HPU" paths: @@ -125,9 +123,7 @@ subprojects: # the examples are used in the app CI - "examples/app_*" checks: - - 'App.cloud-e2e (App_cloud_e2e_testing App: template_streamlit_ui)' - - 'App.cloud-e2e (App_cloud_e2e_testing App: boring_app)' - - 'App.cloud-e2e (App_cloud_e2e_testing App: v0_app)' + - 'App.cloud-e2e' - "doctest (app)" - "make-docs (app)" - "pytest (macOS-11, 3.8, latest)" @@ -141,9 +137,7 @@ subprojects: paths: - ".azure/app-cloud-e2e.yml" checks: - - 'App.cloud-e2e (App_cloud_e2e_testing App: template_streamlit_ui)' - - 'App.cloud-e2e (App_cloud_e2e_testing App: boring_app)' - - 'App.cloud-e2e (App_cloud_e2e_testing App: v0_app)' + - 'App.cloud-e2e' - id: "lightning_app: Docs" paths: From 07401d2b8ecc2ff3bc4ba05091105e97c9be67b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 18:56:29 +0200 Subject: [PATCH 4/7] Quotes --- .github/checkgroup.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 21c2cb9819ef8..7ec9fb8d1a7f1 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -123,7 +123,7 @@ subprojects: # the examples are used in the app CI - "examples/app_*" checks: - - 'App.cloud-e2e' + - "App.cloud-e2e" - "doctest (app)" - "make-docs (app)" - "pytest (macOS-11, 3.8, latest)" @@ -137,7 +137,7 @@ subprojects: paths: - ".azure/app-cloud-e2e.yml" checks: - - 'App.cloud-e2e' + - "App.cloud-e2e" - id: "lightning_app: Docs" paths: From a573f31c1586ead29bd103c7642dbcb6cf294332 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 19:06:57 +0200 Subject: [PATCH 5/7] Add warning --- .github/checkgroup.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 7ec9fb8d1a7f1..96dc90e785656 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -1,4 +1,7 @@ custom_service_name: "Lightning CI required checker" +# For security reasons, configuration is only loaded from the repository's default branch, +# changes made in pull requests from different branches or forks are ignored. This means that changes to this file +# will only be used after they are merged. subprojects: - id: "CI: CircleCI" paths: From 737a902fee1d45f1ce66dc92ab013dc0f50a8654 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 20:08:45 +0200 Subject: [PATCH 6/7] Standalone tests --- .github/checkgroup.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 96dc90e785656..f6177d0f60c2b 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -56,6 +56,7 @@ subprojects: - id: "pytorch_lightning: Azure GPU" paths: - ".azure/gpu-tests.yml" + - "tests/tests_pytorch/run_standalone_*.sh" checks: - "pytorch-lightning (GPUs)" From 9e22e75324f3b5fedaf02eb5e3fd0ed83c0696b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Tue, 23 Aug 2022 23:55:00 +0200 Subject: [PATCH 7/7] Update .github/checkgroup.yml Co-authored-by: Jirka Borovec --- .github/checkgroup.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index f6177d0f60c2b..ace786f8ac40a 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -65,7 +65,6 @@ subprojects: - ".azure/hpu-tests.yml" checks: - "pytorch-lightning (HPUs)" - - "pytorch-lightning (IPUs)" - id: "pytorch_lightning: Azure IPU" paths: