Print the logs when TPU tests fail #15533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
approved these changes
Nov 4, 2022
Borda
approved these changes
Nov 4, 2022
Borda
pushed a commit
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 7a8cf4e)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
(cherry picked from commit 7a8cf4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The logs weren't getting printed if the job failed.
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @carmocca @akihironitta @Borda