From 833318f86e498ab4956f4c40bbb491634330be34 Mon Sep 17 00:00:00 2001 From: Aniket Maurya Date: Fri, 11 Nov 2022 13:13:18 +0530 Subject: [PATCH 1/3] add title and description --- src/lightning_app/components/serve/gradio.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/lightning_app/components/serve/gradio.py b/src/lightning_app/components/serve/gradio.py index 7e7801925937f..328e70e743b43 100644 --- a/src/lightning_app/components/serve/gradio.py +++ b/src/lightning_app/components/serve/gradio.py @@ -31,6 +31,8 @@ class ServeGradio(LightningWork, abc.ABC): outputs: Any examples: Optional[List] = None enable_queue: bool = False + title: Optional[str] = None + description: Optional[str] = None def __init__(self, *args, **kwargs): requires("gradio")(super().__init__(*args, **kwargs)) @@ -58,7 +60,14 @@ def run(self, *args, **kwargs): self._model = self.build_model() fn = partial(self.predict, *args, **kwargs) fn.__name__ = self.predict.__name__ - gradio.Interface(fn=fn, inputs=self.inputs, outputs=self.outputs, examples=self.examples).launch( + gradio.Interface( + fn=fn, + inputs=self.inputs, + outputs=self.outputs, + examples=self.examples, + title=self.title, + description=self.description, + ).launch( server_name=self.host, server_port=self.port, enable_queue=self.enable_queue, From 556c3b6bbd85a434ddaf0b6cb38c4574b003b849 Mon Sep 17 00:00:00 2001 From: Aniket Maurya Date: Fri, 11 Nov 2022 15:21:00 +0530 Subject: [PATCH 2/3] update test --- tests/tests_app/components/serve/test_gradio.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/tests_app/components/serve/test_gradio.py b/tests/tests_app/components/serve/test_gradio.py index 8dcdeec70a341..840ec0138606d 100644 --- a/tests/tests_app/components/serve/test_gradio.py +++ b/tests/tests_app/components/serve/test_gradio.py @@ -27,4 +27,6 @@ def predict(self, *args, **kwargs): comp.run() assert comp.model == "model" assert comp.predict() == "prediction" - gradio_mock.Interface.assert_called_once_with(fn=ANY, inputs=ANY, outputs=ANY, examples=ANY) + gradio_mock.Interface.assert_called_once_with( + fn=ANY, inputs=ANY, outputs=ANY, examples=ANY, title=ANY, description=ANY + ) From 84606f81cc3111b6602f6f2ea302a129c0c99166 Mon Sep 17 00:00:00 2001 From: Aniket Maurya Date: Fri, 11 Nov 2022 18:27:51 +0530 Subject: [PATCH 3/3] apply suggestions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Adrian Wälchli --- tests/tests_app/components/serve/test_gradio.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tests_app/components/serve/test_gradio.py b/tests/tests_app/components/serve/test_gradio.py index 840ec0138606d..0b57656e6aa31 100644 --- a/tests/tests_app/components/serve/test_gradio.py +++ b/tests/tests_app/components/serve/test_gradio.py @@ -28,5 +28,5 @@ def predict(self, *args, **kwargs): assert comp.model == "model" assert comp.predict() == "prediction" gradio_mock.Interface.assert_called_once_with( - fn=ANY, inputs=ANY, outputs=ANY, examples=ANY, title=ANY, description=ANY + fn=ANY, inputs=ANY, outputs=ANY, examples=ANY, title=None, description=None )