From 190eba906d494394a4365b809b86a6cfd87f7e78 Mon Sep 17 00:00:00 2001 From: Akihiro Nitta Date: Fri, 9 Dec 2022 23:23:28 +0900 Subject: [PATCH 1/5] change msg --- src/lightning_app/components/serve/python_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lightning_app/components/serve/python_server.py b/src/lightning_app/components/serve/python_server.py index c522a25eb3f3d..7cfbb375c2555 100644 --- a/src/lightning_app/components/serve/python_server.py +++ b/src/lightning_app/components/serve/python_server.py @@ -227,5 +227,5 @@ def run(self, *args: Any, **kwargs: Any) -> Any: fastapi_app = FastAPI() self._attach_predict_fn(fastapi_app) - logger.info(f"Your app has started. View it in your browser: http://{self.host}:{self.port}") + logger.info(f"Your work has started. View it in your browser: http://{self.host}:{self.port}") uvicorn.run(app=fastapi_app, host=self.host, port=self.port, log_level="error") From 16f65d05b9e5939340be7326fef071bdd99848b6 Mon Sep 17 00:00:00 2001 From: Akihiro Nitta Date: Fri, 9 Dec 2022 23:24:26 +0900 Subject: [PATCH 2/5] change msg --- src/lightning_app/components/serve/python_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lightning_app/components/serve/python_server.py b/src/lightning_app/components/serve/python_server.py index 7cfbb375c2555..6a044617842ae 100644 --- a/src/lightning_app/components/serve/python_server.py +++ b/src/lightning_app/components/serve/python_server.py @@ -227,5 +227,5 @@ def run(self, *args: Any, **kwargs: Any) -> Any: fastapi_app = FastAPI() self._attach_predict_fn(fastapi_app) - logger.info(f"Your work has started. View it in your browser: http://{self.host}:{self.port}") + logger.info(f"Your PythonServer has started. View it in your browser: http://{self.host}:{self.port}") uvicorn.run(app=fastapi_app, host=self.host, port=self.port, log_level="error") From 5fc4968131d5dcf6da07b533100f97b3aeecb023 Mon Sep 17 00:00:00 2001 From: Akihiro Nitta Date: Fri, 9 Dec 2022 23:33:04 +0900 Subject: [PATCH 3/5] update chgl --- src/lightning_app/CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lightning_app/CHANGELOG.md b/src/lightning_app/CHANGELOG.md index 8c830c62ef4ba..0d4545f1f9218 100644 --- a/src/lightning_app/CHANGELOG.md +++ b/src/lightning_app/CHANGELOG.md @@ -40,6 +40,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Fixed Registration for CloudComputes of Works in `L.app.structures` ([#15964](https://github.com/Lightning-AI/lightning/pull/15964)) +- Fixed `PythonServer` messaging "Your app has started" ([#15989](https://github.com/Lightning-AI/lightning/pull/15989)) + + ## [1.8.4] - 2022-12-08 ### Added From 0ef08c1c21364a8a2e30d1ff7cc50bda2e7babca Mon Sep 17 00:00:00 2001 From: Akihiro Nitta Date: Sat, 10 Dec 2022 01:03:00 +0900 Subject: [PATCH 4/5] show the user's class name --- src/lightning_app/components/serve/python_server.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lightning_app/components/serve/python_server.py b/src/lightning_app/components/serve/python_server.py index 6a044617842ae..c8b72a48cb24b 100644 --- a/src/lightning_app/components/serve/python_server.py +++ b/src/lightning_app/components/serve/python_server.py @@ -227,5 +227,7 @@ def run(self, *args: Any, **kwargs: Any) -> Any: fastapi_app = FastAPI() self._attach_predict_fn(fastapi_app) - logger.info(f"Your PythonServer has started. View it in your browser: http://{self.host}:{self.port}") + logger.info( + f"Your {self.__class__.__qualname__} has started. View it in your browser: http://{self.host}:{self.port}" + ) uvicorn.run(app=fastapi_app, host=self.host, port=self.port, log_level="error") From b349d00047964adedcb88e87dcd4d47c145287c7 Mon Sep 17 00:00:00 2001 From: Akihiro Nitta Date: Tue, 13 Dec 2022 16:39:34 +0900 Subject: [PATCH 5/5] Update src/lightning_app/CHANGELOG.md --- src/lightning_app/CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lightning_app/CHANGELOG.md b/src/lightning_app/CHANGELOG.md index 113c04e1bf130..9efa55b3fe584 100644 --- a/src/lightning_app/CHANGELOG.md +++ b/src/lightning_app/CHANGELOG.md @@ -34,7 +34,6 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Fixed `AutoScaler` raising an exception when non-default cloud compute is specified ([#15991](https://github.com/Lightning-AI/lightning/pull/15991)) - ## [1.8.4] - 2022-12-08 ### Added