From e040153df26be2cb1afe2bbd1d3b7ac0fe7bff1d Mon Sep 17 00:00:00 2001 From: Al3xDo Date: Wed, 14 Dec 2022 17:11:43 +0700 Subject: [PATCH 1/3] adding hint to logger error messages --- .../trainer/connectors/logger_connector/fx_validator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py b/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py index f1478ecbf9cbe..de0ee4c34154e 100644 --- a/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py +++ b/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py @@ -174,7 +174,7 @@ def check_logging(cls, fx_name: str) -> None: ) if cls.functions[fx_name] is None: - raise MisconfigurationException(f"You can't `self.log()` inside `{fx_name}`.") + raise MisconfigurationException(f"You can't `self.log()` inside `{fx_name}`. HINT: You can still log directly to the logger by using `self.logger.experiment`.") @classmethod def get_default_logging_levels( From 9ac2933e21b41efe6696cbba3ea7cadeb8b16dfb Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Wed, 14 Dec 2022 10:13:35 +0000 Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- .../trainer/connectors/logger_connector/fx_validator.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py b/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py index de0ee4c34154e..adca5743139c4 100644 --- a/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py +++ b/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py @@ -174,7 +174,9 @@ def check_logging(cls, fx_name: str) -> None: ) if cls.functions[fx_name] is None: - raise MisconfigurationException(f"You can't `self.log()` inside `{fx_name}`. HINT: You can still log directly to the logger by using `self.logger.experiment`.") + raise MisconfigurationException( + f"You can't `self.log()` inside `{fx_name}`. HINT: You can still log directly to the logger by using `self.logger.experiment`." + ) @classmethod def get_default_logging_levels( From 1954d87e40337a91adf74a10cdf45979afc15444 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Wed, 14 Dec 2022 12:39:45 +0100 Subject: [PATCH 3/3] Break line --- .../trainer/connectors/logger_connector/fx_validator.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py b/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py index adca5743139c4..686d3a364cbf4 100644 --- a/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py +++ b/src/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py @@ -175,7 +175,8 @@ def check_logging(cls, fx_name: str) -> None: if cls.functions[fx_name] is None: raise MisconfigurationException( - f"You can't `self.log()` inside `{fx_name}`. HINT: You can still log directly to the logger by using `self.logger.experiment`." + f"You can't `self.log()` inside `{fx_name}`. HINT: You can still log directly to the logger by using" + " `self.logger.experiment`." ) @classmethod