Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 23, 2023

What does this PR do?

Fixes #16852

One can either mark the test standalone, or fix the strategy to ddp_spawn. I chose the latter.

cc @carmocca @justusschock @awaelchli @Borda

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Feb 23, 2023
@awaelchli awaelchli added tests bug Something isn't working labels Feb 23, 2023
@awaelchli awaelchli added this to the 2.0 milestone Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.9, 1.11) success
fabric-cpu (windows-2022, lightning, 3.10, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_amp_integration.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success

These checks are required after the changes to tests/tests_fabric/plugins/precision/test_amp_integration.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 23, 2023
@awaelchli awaelchli merged commit 462f1ee into master Feb 24, 2023
@awaelchli awaelchli deleted the debug/fabric-amp-test branch February 24, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fabric lightning.fabric.Fabric ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fabric mixed precision test fails with multiple CUDA devices

3 participants