Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving native AMP scaler state #1777

Merged

Conversation

kepler
Copy link
Contributor

@kepler kepler commented May 11, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes saving native AMP scaler state that was introduced in #1561.

PR review

Anyone in the community is free to review the PR once the tests have passed.

@mergify mergify bot requested a review from a team May 11, 2020 09:56
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #1777 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1777   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        4302    4302           
======================================
  Hits         3793    3793           
  Misses        509     509           

@Borda Borda requested a review from williamFalcon May 11, 2020 10:46
@williamFalcon williamFalcon merged commit d120f97 into Lightning-AI:master May 12, 2020
@kepler kepler deleted the bugfix/save-native-amp-scaler branch May 12, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants