Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: enable self.log for eval loop metrics #3715

Merged
merged 6 commits into from
Sep 29, 2020
Merged

ref: enable self.log for eval loop metrics #3715

merged 6 commits into from
Sep 29, 2020

Conversation

williamFalcon
Copy link
Contributor

Finishing self.log for eval steps.

  • Automatically sets on_step vs on_epoch depending which loop is called as well

@mergify mergify bot requested a review from a team September 29, 2020 04:36
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #3715 into master will increase coverage by 3%.
The diff coverage is 95%.

@@           Coverage Diff           @@
##           master   #3715    +/-   ##
=======================================
+ Coverage      86%     89%    +3%     
=======================================
  Files         110     110            
  Lines        8220    8579   +359     
=======================================
+ Hits         7069    7626   +557     
+ Misses       1151     953   -198     

@williamFalcon williamFalcon merged commit f42ea30 into master Sep 29, 2020
@Borda Borda deleted the vl1 branch September 30, 2020 10:55
@Borda Borda added the refactor label Oct 2, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants