Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 3, 2021

What does this PR do?

Installing collected packages: torch, torchtext
  WARNING: The scripts convert-caffe2-to-onnx and convert-onnx-to-caffe2 are installed in '/home/AzDevOps_azpcontainer/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
torchvision 0.7.0 requires torch==1.6.0, but you have torch 1.7.1 which is incompatible.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Mar 3, 2021
@Borda Borda added this to the 1.2.x milestone Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #6323 (59ee024) into master (dcec4ef) will decrease coverage by 0%.
The diff coverage is 88%.

@@          Coverage Diff           @@
##           master   #6323   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files         160     160           
  Lines       11398   11408   +10     
======================================
+ Hits        10376   10377    +1     
- Misses       1022    1031    +9     

@Borda Borda changed the title hotfix for torchtext hotfix for PT1.6 and torchtext Mar 3, 2021
@Borda Borda marked this pull request as ready for review March 3, 2021 15:04
@Borda Borda requested a review from tchaton as a code owner March 3, 2021 15:04
@tchaton tchaton enabled auto-merge (squash) March 3, 2021 15:20
@Borda
Copy link
Collaborator Author

Borda commented Mar 3, 2021

the remaining failers are unrelated to this change
also, this dependency shall be properly resolved in the docker build

@Borda Borda requested a review from awaelchli as a code owner March 3, 2021 19:30
@Borda
Copy link
Collaborator Author

Borda commented Mar 3, 2021

so the last missing is TPU @tchaton

@Borda
Copy link
Collaborator Author

Borda commented Mar 4, 2021

 # TorchVision hotfix https://github.com/pytorch/vision/issues/1938
 from syft.util import get_root_data_path
 from six.moves import urllib
 opener = urllib.request.build_opener()
 opener.addheaders = [(\"User-agent\", \"Mozilla/5.0\")]
 urllib.request.install_opener(opener)

Comment on lines +70 to +71
# todo: some strange failure
./tests/callbacks/test_pruning.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea about this? I can have a look... but should have anything to do with torchtext 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it is unrelated and even the check details can't be found in codebase

@Borda
Copy link
Collaborator Author

Borda commented Mar 4, 2021

@Borda Borda disabled auto-merge March 4, 2021 16:48
@Borda Borda merged commit e038e74 into master Mar 4, 2021
@Borda Borda deleted the ci/torchtext branch March 4, 2021 16:48
Borda added a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 4, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review

(cherry picked from commit e038e74)
Borda added a commit to kaushikb11/pytorch-lightning that referenced this pull request Mar 4, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review

(cherry picked from commit e038e74)
@Borda Borda mentioned this pull request Mar 5, 2021
11 tasks
lexierule pushed a commit that referenced this pull request Mar 5, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review

(cherry picked from commit e038e74)
@tchaton tchaton mentioned this pull request Mar 8, 2021
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review
Borda added a commit that referenced this pull request Mar 9, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review
tchaton pushed a commit that referenced this pull request Mar 9, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review
lexierule pushed a commit that referenced this pull request Mar 9, 2021
* ci: azure reinstall torchtext

* move

* todos

* 0.6.0

* skip examples

* formatter

* skip

* todo

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants