Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

Removes redundant test

This is already covered by:

https://github.com/PyTorchLightning/pytorch-lightning/blob/1c013b43e049d423184323313014774738827c90/tests/models/test_hooks.py#L262

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added ci Continuous Integration refactor labels Mar 10, 2021
@carmocca carmocca added this to the 1.3 milestone Mar 10, 2021
@carmocca carmocca self-assigned this Mar 10, 2021
@carmocca carmocca added the ready PRs ready to be merged label Mar 10, 2021
@Borda Borda merged commit d1db604 into master Mar 10, 2021
@Borda Borda deleted the cleanup-test branch March 10, 2021 19:16
@carmocca carmocca mentioned this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants