Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated sync step argument from WandbLogger #8763

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 6, 2021

What does this PR do?

The sync step argument is deprecated and can be removed now.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #8763 (a457477) into master (8473cf4) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8763   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         169     169           
  Lines       14072   14070    -2     
======================================
- Hits        13041   13039    -2     
  Misses       1031    1031           

@awaelchli awaelchli added logger Related to the Loggers refactor labels Aug 6, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 6, 2021
@carmocca carmocca added the breaking change Includes a breaking change label Aug 6, 2021
@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2021
@Borda Borda merged commit 87093a3 into master Aug 9, 2021
@Borda Borda deleted the feature/remove-sync-step branch August 9, 2021 07:45
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change logger Related to the Loggers ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants