Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trainer.lightning_module in CallbackConnector._attach_callbacks #8805

Merged

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Aug 9, 2021

What does this PR do?

Follow up to #8536 (comment)

self.model is an nn.Module. it's not guaranteed to be a LightningModule, which has configure_callbacks defined

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #8805 (fdfae63) into master (f1cc6e3) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8805    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14068   14068            
=======================================
- Hits        13038   12460   -578     
- Misses       1030    1608   +578     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@carmocca carmocca added this to the v1.5 milestone Aug 9, 2021
@carmocca carmocca added the bug Something isn't working label Aug 9, 2021
@tchaton tchaton enabled auto-merge (squash) August 9, 2021 13:53
@tchaton tchaton added the ready PRs ready to be merged label Aug 9, 2021
@mergify mergify bot requested a review from a team August 9, 2021 13:54
@ananthsub ananthsub force-pushed the fix/callback-connector-model-attach branch from 6b16351 to fdfae63 Compare August 9, 2021 15:33
@tchaton tchaton merged commit 15f6eca into Lightning-AI:master Aug 10, 2021
@ananthsub ananthsub deleted the fix/callback-connector-model-attach branch August 10, 2021 04:21
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants