-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate prepare_data_per_node
flag on Trainer and set it as a property for DataHooks
#8958
Merged
carmocca
merged 36 commits into
Lightning-AI:master
from
ninginthecloud:refactor_issue8733
Aug 23, 2021
Merged
Deprecate prepare_data_per_node
flag on Trainer and set it as a property for DataHooks
#8958
carmocca
merged 36 commits into
Lightning-AI:master
from
ninginthecloud:refactor_issue8733
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8958 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 175 175
Lines 14379 14391 +12
=======================================
- Hits 13322 12749 -573
- Misses 1057 1642 +585 |
This PR needs rebase, I will update soon. |
yifuwang
reviewed
Aug 17, 2021
yifuwang
reviewed
Aug 17, 2021
tchaton
reviewed
Aug 17, 2021
Dear @ninginthecloud, Let's use human readable title for PR :) Best, |
ananthsub
reviewed
Aug 17, 2021
ninginthecloud
force-pushed
the
refactor_issue8733
branch
from
August 17, 2021 18:55
9f35b7c
to
95cdf0d
Compare
ninginthecloud
changed the title
Refactor issue8733
[Refactor] Move prepare_data_per_node to the DataHooks class
Aug 17, 2021
ananthsub
reviewed
Aug 17, 2021
ninginthecloud
commented
Aug 17, 2021
ninginthecloud
changed the title
[Refactor] Move prepare_data_per_node to the DataHooks class
Deprecate Aug 18, 2021
prepare_data_per_node
flag on Trainer and set it as a property for DataHooks
ninginthecloud
force-pushed
the
refactor_issue8733
branch
from
August 18, 2021 06:56
95cdf0d
to
eb3870e
Compare
tchaton
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ananthsub
reviewed
Aug 18, 2021
ananthsub
reviewed
Aug 18, 2021
ananthsub
reviewed
Aug 18, 2021
ninginthecloud
force-pushed
the
refactor_issue8733
branch
from
August 18, 2021 20:04
eb3870e
to
752098d
Compare
ananthsub
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren and
williamFalcon
as code owners
August 18, 2021 20:06
ananthsub
reviewed
Aug 18, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
ninginthecloud
force-pushed
the
refactor_issue8733
branch
from
August 23, 2021 04:08
13d0e1e
to
702cdc8
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data handling
Generic data-related topic
deprecation
Includes a deprecation
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8733
This PR has completed the following:
DataHooks
withprepare_data_per_node
propertyprepare_data_per_node
intrainer
as optionalon_trainer_init
function indata_connector
classtest_datamodules.py
andtest_hooks.py
prepare_data()
implementation and removecan_prepare_data()
indata_connector
classDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃