From 6cce7094310cf7be7996fabef3f3e294f17f5346 Mon Sep 17 00:00:00 2001
From: Kaushik B <kaushikbokka@gmail.com>
Date: Tue, 17 May 2022 00:13:31 +0530
Subject: [PATCH 1/2] Update warpdrive tutorial

---
 lightning_examples/warp-drive/.meta.yml         |  3 ---
 lightning_examples/warp-drive/multi_agent_rl.py | 10 ++++++++++
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/lightning_examples/warp-drive/.meta.yml b/lightning_examples/warp-drive/.meta.yml
index 9a65f6545..e76c00af7 100644
--- a/lightning_examples/warp-drive/.meta.yml
+++ b/lightning_examples/warp-drive/.meta.yml
@@ -18,8 +18,5 @@ description: This notebook introduces multi-agent reinforcement learning (MARL)
     documentation - http://opensource.salesforce.com/warp-drive/, and
     white paper - https://arxiv.org/abs/2108.13976.
 
-requirements:
-  - rl-warp-drive>=1.6.5
-  - ffmpeg-python
 accelerator:
   - GPU
diff --git a/lightning_examples/warp-drive/multi_agent_rl.py b/lightning_examples/warp-drive/multi_agent_rl.py
index d4c5ec8c6..dc78d493f 100644
--- a/lightning_examples/warp-drive/multi_agent_rl.py
+++ b/lightning_examples/warp-drive/multi_agent_rl.py
@@ -1,3 +1,11 @@
+# %%
+import sys
+
+if "google.colab" in sys.modules:
+    ! pip uninstall --quiet "torchaudio" "torchvision" "torchtext" "fastai" "datascience" "kapre" --yes
+    ! pip install --quiet "rl-warp-drive>=1.6.5" "pytorch-lightning>=1.4"
+else:
+    ! pip install --quiet "ipython[notebook]" "rl-warp-drive>=1.6.5" "ffmpeg-python" "setuptools==59.5.0" "torch>=1.8" "torchmetrics>=0.7" "pytorch-lightning>=1.4"
 # %% [markdown]
 # **⚠️ PLEASE NOTE:**
 # This notebook runs on a GPU runtime. If running on Colab, choose Runtime > Change runtime type from the menu, then select `GPU` in the 'Hardware accelerator' dropdown menu.
@@ -225,6 +233,8 @@
     devices=num_gpus,
     callbacks=[cuda_callback, perf_stats_callback],
     max_epochs=num_epochs,
+    log_every_n_steps=1,
+    reload_dataloaders_every_n_epochs=1,
 )
 
 # %%

From 93d358d4168f20003e0270eb3cd95aa61ac4abf0 Mon Sep 17 00:00:00 2001
From: Jirka Borovec <Borda@users.noreply.github.com>
Date: Tue, 17 May 2022 06:56:55 +0200
Subject: [PATCH 2/2] Apply suggestions from code review

---
 lightning_examples/warp-drive/.meta.yml         | 7 +++++++
 lightning_examples/warp-drive/multi_agent_rl.py | 8 --------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/lightning_examples/warp-drive/.meta.yml b/lightning_examples/warp-drive/.meta.yml
index e76c00af7..988bfde35 100644
--- a/lightning_examples/warp-drive/.meta.yml
+++ b/lightning_examples/warp-drive/.meta.yml
@@ -18,5 +18,12 @@ description: This notebook introduces multi-agent reinforcement learning (MARL)
     documentation - http://opensource.salesforce.com/warp-drive/, and
     white paper - https://arxiv.org/abs/2108.13976.
 
+requirements:
+  - rl-warp-drive>=1.6.5
+  - ffmpeg-python
+  # todo: after merging #155 we will relax this just to `torch<=1.10` and drop TV, TT, etc.
+  - torch==1.10.*
+  - torchvision==0.11.*
+  - torchtext==0.11.*
 accelerator:
   - GPU
diff --git a/lightning_examples/warp-drive/multi_agent_rl.py b/lightning_examples/warp-drive/multi_agent_rl.py
index dc78d493f..753dd2836 100644
--- a/lightning_examples/warp-drive/multi_agent_rl.py
+++ b/lightning_examples/warp-drive/multi_agent_rl.py
@@ -1,11 +1,3 @@
-# %%
-import sys
-
-if "google.colab" in sys.modules:
-    ! pip uninstall --quiet "torchaudio" "torchvision" "torchtext" "fastai" "datascience" "kapre" --yes
-    ! pip install --quiet "rl-warp-drive>=1.6.5" "pytorch-lightning>=1.4"
-else:
-    ! pip install --quiet "ipython[notebook]" "rl-warp-drive>=1.6.5" "ffmpeg-python" "setuptools==59.5.0" "torch>=1.8" "torchmetrics>=0.7" "pytorch-lightning>=1.4"
 # %% [markdown]
 # **⚠️ PLEASE NOTE:**
 # This notebook runs on a GPU runtime. If running on Colab, choose Runtime > Change runtime type from the menu, then select `GPU` in the 'Hardware accelerator' dropdown menu.