Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error position detention at WRITE PERM #357
Improve error position detention at WRITE PERM #357
Changes from all commits
551d215
2d28b3c
dc9d1b2
a42ff40
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piste-jp-ibm So if last_index_pos is "the end of the partition" you are moving error_pos to the end of the partition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is first block of the index. But it is enough because every extents must not have that block at all.
So LTFS sets the last position on tape to
last_index_pos + 1
and cleanup extents. As a result, all extents after the last index will be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piste-jp-ibm so LTFS always uses fixed length never variable length right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, a extent is constructed from one or more 512KB fixed blocks and no or one variable block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piste-jp-ibm at first glance I would have thought on this line as the guilty of the overwriting of the previous block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. this line is one of the root cause. But logic itself is correct. The idea how to fetch the error position is bad.
We thought that the only way to fetch the error position is subtract number of records in buffer from the current position. But this idea is not good when a WRITE PERM happens just after a locate (for append). Because the drive mould have records which is read by the locate in buffer.
Actually, we realized error position it self is provided by READ_POSITION command.