Apply suggestions from code review

Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
LinuxForHealth · Mar 30, 2021 · b60692e · b60692e
1 parent 847687f
commit b60692e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...n-bulkdata/src/main/java/com/ibm/fhir/operation/bulkdata/config/ConfigurationAdapter.java b/...n-bulkdata/src/main/java/com/ibm/fhir/operation/bulkdata/config/ConfigurationAdapter.java
@@ -216,7 +216,7 @@ public interface ConfigurationAdapter {
     String getCoreIamEndpoint();
 
     /**
-     * get the tx for the fast chunk read during an sexport
+     * get the number ms to read payloads from the persistence layer before stopping to checkpoint
      *
      * @return
      */
@@ -472,4 +472,4 @@ public interface ConfigurationAdapter {
      * @return
      */
     int getPresignedUrlExpiry();
-}
+}
diff --git a/...ain/java/com/ibm/fhir/operation/bulkdata/config/impl/AbstractSystemConfigurationImpl.java b/...ain/java/com/ibm/fhir/operation/bulkdata/config/impl/AbstractSystemConfigurationImpl.java
@@ -320,7 +320,7 @@ public int getImportInflyRateNumberOfFhirResources(String provider) {
 
     @Override
     public int getPresignedUrlExpiry() {
-        int pageSize = FHIRConfigHelper.getIntProperty("fhirServer/bulkdata/core/cos/presignedExpiry", 86400);
-        return Math.max(1, pageSize);
+        int expirySeconds = FHIRConfigHelper.getIntProperty("fhirServer/bulkdata/core/cos/presignedExpiry", 86400);
+        return Math.max(1, expirySeconds);
     }
-}
+}