Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated commit() and rollback() methods from FHIRPersistenceTransaction #1304

Closed
punktilious opened this issue Jun 30, 2020 · 1 comment
Closed

Remove deprecated commit() and rollback() methods from FHIRPersistenceTransaction #1304

punktilious opened this issue Jun 30, 2020 · 1 comment
Assignees
@prb112
Labels
enhancement New feature or request
Milestone
Sprint 2021-04

Comments

@punktilious
Copy link
Collaborator

Describe the bug
The FHIRPersistenceTransaction API has changed. To support backward compatibility, the commit() and rollback() methods have been kept, but are now flagged as deprecated. They should be removed in a future release. This will require consumers of the JDBC persistence component to update their transaction handling code to use the new (simplified) pattern.

This change is designed to promote greater consistency in how transactions and related errors are handled.

Expected behavior
FHIRPersistenceTransaction should support only begin(), end() and setRollbackOnly()
@punktilious punktilious added the enhancement New feature or request label Jun 30, 2020
prb112 added a commit that referenced this issue Mar 26, 2021
@prb112
Remove deprecated commit() and rollback() methods from
6bab1f0 
FHIRPersistenceTransaction #1304

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 mentioned this issue Mar 26, 2021
Merged
@prb112
Copy link
Contributor

prb112 commented Mar 26, 2021

Feels like an easy 4.7.0 one

@prb112 prb112 self-assigned this Mar 26, 2021
@prb112 prb112 added this to the Sprint 2021-04 milestone Mar 26, 2021
prb112 added a commit that referenced this issue Mar 26, 2021
@prb112
Remove deprecated commit() and rollback() methods from
4c32c9f 
FHIRPersistenceTransaction #1304

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 2021-04
Development

No branches or pull requests
2 participants
@prb112 @punktilious