Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make useStoredCompartmentParam the default #2111

Closed
lmsurpre opened this issue Mar 18, 2021 · 1 comment
Closed

Make useStoredCompartmentParam the default #2111

lmsurpre opened this issue Mar 18, 2021 · 1 comment
Assignees

Comments

@lmsurpre
Copy link
Member

Is your feature request related to a problem? Please describe.
I’d like to make useStoredCompartmentParam default to true. We added this in 4.5.1 and left it behind a flag since, if you’re migrating from before 4.5.1, it requires a reindex to work. Now that we're on 4.6.x, its time to make this the default.

Describe the solution you'd like
Flip the default from false to true, and add "useStoredCompartmentParam": true to our default config

Describe alternatives you've considered

  • Keep the default as false but add "useStoredCompartmentParam": true to our default config; or
  • Flip the default from false to true, but add "useStoredCompartmentParam": false to our default config; or
  • Flip the default from false to true, keep the parameter out of our default config, and mark the parameter as deprecated

Additional context
Now that we're using inclusionCriteria queries from bulk data (patient/group export) and fhir-smart (policy enforcement interceptor), this can have even more benefit.

@lmsurpre lmsurpre added this to the Sprint 2021-04 milestone Mar 18, 2021
@lmsurpre lmsurpre self-assigned this Mar 18, 2021
lmsurpre added a commit that referenced this issue Mar 18, 2021
and add it to our default fhir-server-config.json

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 18, 2021
and add it to our default fhir-server-config.json

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 18, 2021
and add it to our default fhir-server-config.json

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 19, 2021
and add it to our default fhir-server-config.json

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 19, 2021
and add it to our default fhir-server-config.json

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 19, 2021
and add it to our default fhir-server-config.json

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@prb112
Copy link
Contributor

prb112 commented Mar 23, 2021

I've tested compartment searches with GroupExport, Patient Export, regular rest calls with false, default, true.
It's working as outlined in the issue.

@prb112 prb112 closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants