Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Pattern Value Constraint with $this in the Path #2377

Closed
prb112 opened this issue May 18, 2021 · 4 comments
Closed

Add Support for Pattern Value Constraint with $this in the Path #2377

prb112 opened this issue May 18, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@prb112
Copy link
Contributor

prb112 commented May 18, 2021

Is your feature request related to a problem? Please describe.
Add Support for Pattern Value Constraint with $this in the Path

support canonical pattern value constraints

We generate a constraint = "generated-C4BB-Organization-1: Constraint violation: meta.where(lastUpdated.exists() and profile = 'http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Organization%7C1.0.0').exists()"
should this be = or an in http://hl7.org/fhirpath/#in-membership
Currently, we say the following is an error, however profile is an array...

{
  "resourceType" : "Organization",
  "id" : "OrganizationProvider1",
  "meta" : {
    "lastUpdated" : "2019-12-12T09:14:11+00:00",
    "profile" : [
      "http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Organization",
      "http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Organization|1.0.0"
    ]
  }
}

https://build.fhir.org/ig/HL7/carin-bb/Organization-OrganizationProvider1.html

they had a constraint on the number of profiles, I'm opening a JIRA issue for it

@lmsurpre
Copy link
Member

lmsurpre commented May 18, 2021

they had a constraint on the number of profiles, I'm opening a JIRA issue for it

image

What they're trying to say here is that exactly one of the profiles must be http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Organization%7C1.0.0.
The profile element itself is 1..*, its just the slice with this pattern that is 1..1.

Net: I think this is solely our issue and I think the IG is just fine.

@lmsurpre lmsurpre added this to the Sprint 2021-07 milestone May 18, 2021
@prb112
Copy link
Contributor Author

prb112 commented May 18, 2021

hum... I thought this asserted that the canonical pattern has to be...

@prb112 prb112 added the enhancement New feature or request label May 18, 2021
@prb112 prb112 changed the title support canonical pattern value constraints Add Support for Pattern Value Constraint with $this in the Path May 19, 2021
JohnTimm added a commit that referenced this issue May 19, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 19, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 19, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
lmsurpre pushed a commit that referenced this issue May 19, 2021
* Issue #2377 - update ConstraintGenerator

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 24, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 24, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Jun 7, 2021

@JohnTimm I think you've already implemented this?

@prb112 prb112 closed this as completed Jun 7, 2021
@prb112
Copy link
Contributor Author

prb112 commented Jun 7, 2021

I've already tried this out.
QA done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants