Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $import OperationOutcomes written when a Success #2390

Closed
prb112 opened this issue May 19, 2021 · 3 comments
Closed

Support $import OperationOutcomes written when a Success #2390

prb112 opened this issue May 19, 2021 · 3 comments
Assignees
Labels
bulk-data enhancement New feature or request P2 Priority 2 - Should Have

Comments

@prb112
Copy link
Contributor

prb112 commented May 19, 2021

Is your feature request related to a problem? Please describe.
Support $import OperationOutcomes written when a Success

The current behavior only stores the Error/Warning conditions on a Failure to $import.

{
    "transactionTime": "2021-05-19T19:33:28.828Z",
    "request": "https://localhost:9443/fhir-server/api/v4/$import",
    "requiresAccessToken": false,
    "output": [
        {
            "type": "OperationOutcome",
            "url": "fE66-QcWbrCnzF2sEVmI7Z_m4lKG-S_J4h4r8HvzcuQ/Patient_1.ndjson_oo_success.ndjson",
            "count": 1
        }
    ],
    "error": [
        {
            "type": "OperationOutcome",
            "url": "fE66-QcWbrCnzF2sEVmI7Z_m4lKG-S_J4h4r8HvzcuQ/Patient_1.ndjson_oo_errors.ndjson",
            "count": 1
        }
    ]
}

Describe the solution you'd like
For S3/File import, we want to write Success Outcomes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Acceptance Criteria
1.
GIVEN a Successful Import
AND at least one Warning
WHEN $import is started
AND $import is completed
THEN **oo_success.ndjson is created.
AND there is at least one OperationOutcome for the Successful Import

Additional context
Found in #2083

I suspect this is a 2 pointer.

@prb112 prb112 added enhancement New feature or request bulk-data labels May 19, 2021
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label May 24, 2021
@prb112 prb112 self-assigned this Oct 29, 2021
@prb112
Copy link
Contributor Author

prb112 commented Feb 25, 2022

QA is the same as #2910

@d0roppe
Copy link
Collaborator

d0roppe commented Mar 1, 2022

The import with errors does not fill in the errors file of type ndjson. Following the QA info written up in issue 2910

prb112 added a commit that referenced this issue Mar 3, 2022
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Mar 3, 2022
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@d0roppe
Copy link
Collaborator

d0roppe commented Mar 4, 2022

the error file now has information on what the error wss and from what line number from the input file.

@d0roppe d0roppe closed this as completed Mar 4, 2022
prb112 added a commit that referenced this issue Mar 8, 2022
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Mar 8, 2022
…Statement #3082  (#3441)

* Update for performance #2390

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Optimization for Check on Resource Type

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre pushed a commit that referenced this issue Mar 9, 2022
…Statement #3082  (#3441)

* Update for performance #2390

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

* Optimization for Check on Resource Type

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bulk-data enhancement New feature or request P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

3 participants