Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhir-bucket reindex process should exit with non-zero exit code if it didn't finish with success #2914

Open
lmsurpre opened this issue Oct 28, 2021 · 0 comments
Labels
enhancement New feature or request P2 Priority 2 - Should Have

Comments

@lmsurpre
Copy link
Member

Is your feature request related to a problem? Please describe.
In #2752 we fixed an issue so that the fhir-bucket process will exit when it fails (previously it would hang under particular conditions).

However, as implemented, it will always exit with a status code of 0 (success).

For use from kubernetes jobs, it would be nice if it exited with a non-zero exit code.

Describe the solution you'd like
If we know we're exiting without completing the reindex, throw an exception to exit the program.

Describe alternatives you've considered
Rely on processing the output to determine if the reindex completed with success or not.

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
Add any other context or screenshots about the feature request here.

@prb112 prb112 added the enhancement New feature or request label Oct 29, 2021
@lmsurpre lmsurpre added P3 Priority 3 - Nice To Have P2 Priority 2 - Should Have and removed P3 Priority 3 - Nice To Have labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

2 participants