Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore error message changes for bad conditional references #2946

Closed
lmsurpre opened this issue Nov 5, 2021 · 1 comment
Closed

Restore error message changes for bad conditional references #2946

lmsurpre opened this issue Nov 5, 2021 · 1 comment
Assignees
Labels
bug Something isn't working P2 Priority 2 - Should Have

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Nov 5, 2021

Describe the bug
In 4.9.2 we shipped changes for #2556 so that we get important diagnostic info from bundles with bad conditional references.

Unfortunately, we seem to have lost those edits as part of a large bundle processing refactor on main.

Environment
Which version of IBM FHIR Server?

To Reproduce
Steps to reproduce the behavior:

  1. submit a transaction bundle with conditional references that have 0 or >1 match.

Expected behavior
The response should contain an OperationOutcome.Issue that details:

  1. the value of offending conditional reference (i.e. the query that we barfed on)--probably in the description
  2. the location of the field with this conditional reference (at the very least the Bundle entry's index)--probably in the "expression"

Additional context
See #2772 for what we did for this the last time.

@lmsurpre lmsurpre added the bug Something isn't working label Nov 5, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-15 milestone Nov 5, 2021
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Nov 8, 2021
@lmsurpre lmsurpre self-assigned this Nov 9, 2021
lmsurpre added a commit that referenced this issue Nov 9, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Nov 9, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Nov 9, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Nov 9, 2021
issue #2946 - add conditional reference value and entry index (again)
@kmbarton423
Copy link
Contributor

Confirmed issues created for conditional references in a transaction bundle for the following cases:

  • reference does not resolve
  • reference resolves to multiple
  • reference search is invalid

in all cases the resulting issue contains an expression indicating the location (Bundle.entry[x])
confirmed varied location of failure within the bundle were represented accurately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

2 participants