Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any remaining support for requests to abstract endpoints like [base]/Resource #3265

Closed
lmsurpre opened this issue Feb 1, 2022 · 1 comment
Assignees
Labels
break-change-api r4b removal this change involves removal of a component, class, method, etc technical debt

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Feb 1, 2022

Is your feature request related to a problem? Please describe.
In #2526 we added warnings for requests to "abstract" type endpoints like [base]/Resource.
Now I'd like to pull the trigger and remove that support altogether.

Describe the solution you'd like
have requests to [base]/Resource handled just like requests to [base]/bogus

Describe alternatives you've considered
keep supporting it in whatever way we do today

Acceptance Criteria

  1. GIVEN a 5.0 version of IBM FhIR Server
    WHEN a request is made to [base]/bogus
    THEN it results in a 404 not found

Additional context
one such place is FHIRResource.checkType(String):

if (!ModelSupport.isConcreteResourceType(type)) {
            log.warning("Use of abstract resource types like '" + type + "' in FHIR URLs is deprecated and will be removed in a future release");
}
@lmsurpre lmsurpre added removal this change involves removal of a component, class, method, etc technical debt labels Feb 1, 2022
@lmsurpre lmsurpre changed the title https://github.com/IBM/FHIR/issues/2526 Remove any remaining support for requests to abstract endpoints like [base]/Resource Feb 1, 2022
lmsurpre added a commit that referenced this issue Feb 2, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 2, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 5, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 5, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 5, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre self-assigned this Feb 7, 2022
lmsurpre added a commit that referenced this issue Feb 15, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Feb 16, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 9, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 9, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre added the r4b label Mar 21, 2022
lmsurpre added a commit that referenced this issue Apr 8, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 22, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue May 12, 2022
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@d0roppe
Copy link
Collaborator

d0roppe commented Jun 16, 2022

Error 404 issued with the text the "unknow" text is not a valid resource Closing issue.
The 404 is given for both 4.0 and 4.3 fhir versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-change-api r4b removal this change involves removal of a component, class, method, etc technical debt
Projects
None yet
Development

No branches or pull requests

2 participants