Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for postgresql citus support #3698

Closed
lmsurpre opened this issue Jun 10, 2022 · 3 comments
Closed

Documentation for postgresql citus support #3698

lmsurpre opened this issue Jun 10, 2022 · 3 comments
Assignees
Labels
P2 Priority 2 - Should Have

Comments

@lmsurpre
Copy link
Member

This experimental support was added under #3437

Now we should document what that consists of and how to use it. Probably at least 3 locations:

  1. Updates to the schema design documentation at https://github.com/IBM/FHIR/blob/main/fhir-persistence-schema/docs/SchemaDesign.md
  2. Updates to the schema tool usage guide at https://github.com/IBM/FHIR/blob/main/fhir-persistence-schema/docs/SchemaToolUsageGuide.md
  3. Updates to the User's guide with what feature is and how to configure it
  4. more?
@lmsurpre
Copy link
Member Author

I now see that #3683 does include some updates to the SchemaToolUsageGuide (number 2 in the description), its possible that this part is done (or at least started)

punktilious added a commit that referenced this issue Jun 13, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Jun 20, 2022
punktilious added a commit that referenced this issue Jun 21, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@lmsurpre
Copy link
Member Author

lmsurpre commented Aug 4, 2022

didn't see any mention in the user's guide

please also make sure that any known limitations of the citus implementation are included in the docs

@lmsurpre
Copy link
Member Author

lmsurpre commented Aug 30, 2022

Citus now has its own section in the user's guide under 3.3.1.1 Supported databases.

It also mentions the search limitations of the current impl:

Currently, some FHIR search queries which follow references between resources such as _include, _revinclude and _has do not work. Support for these search queries may be included in a future update.

Future enhancements can come as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority 2 - Should Have
Projects
None yet
Development

No branches or pull requests

2 participants