Implicit base not picked up in FHIR Reference search #300 #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
- Added Integration Test Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre
reviewed
Sep 26, 2020
...sistence/src/test/java/com/ibm/fhir/persistence/search/test/AbstractSearchReferenceTest.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 26, 2020
fhir-persistence/src/test/resources/logging.unitTest.properties
Outdated
Show resolved
Hide resolved
…he tests for SortParameter, the reason is when a refernece is used, we requery it parse the possible values needed in the search Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
|
Once Lee's branch is merged, I'll update the code with a rebase, and pickup the AP fix |
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre
reviewed
Sep 30, 2020
fhir-bulkimportexport-webapp/src/main/java/META-INF/batch-jobs/FhirBulkExportChunkJob.xml
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 30, 2020
...sistence/src/test/java/com/ibm/fhir/persistence/search/test/AbstractSearchReferenceTest.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 30, 2020
fhir-persistence/src/test/resources/logging.unitTest.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
reviewed
Sep 30, 2020
fhir-persistence/src/test/resources/logging.unitTest.properties
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 30, 2020
...peration-bulkdata/src/main/java/com/ibm/fhir/operation/bulkdata/model/type/JobParameter.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 30, 2020
fhir-server-test/src/test/java/com/ibm/fhir/server/test/SearchTest.java
Outdated
Show resolved
Hide resolved
…peration/bulkdata/model/type/JobParameter.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
…Test.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
reviewed
Sep 30, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 30, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Sep 30, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
…java Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
reviewed
Oct 5, 2020
fhir-search/src/test/java/com/ibm/fhir/search/reference/ReferenceTypeTest.java
Show resolved
Hide resolved
lmsurpre
approved these changes
Oct 5, 2020
…reated Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Bastide pbastide@us.ibm.com