Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1323 - Add support for ':of-type' modifier #2116

Merged
merged 5 commits into from
Mar 22, 2021
Merged

Conversation

tbieste
Copy link
Contributor

@tbieste tbieste commented Mar 19, 2021

Issue #1323 - Add support for ':of-type' modifier

Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste
Copy link
Contributor Author

tbieste commented Mar 19, 2021

Given this identifier:

    "identifier": [
        {
            "system": "urn:oid:0.1.2.3.4.5.6.7",
            "type": {
                "coding": [
                    {
                        "code": "MR1",
                        "system": "mysystem1"
                    },
                    {
                        "code": "MR2",
                        "system": "mysystem2"
                    }
                ]
            },
            "value": "333333"
        },
        {
            "system": "urn:oid:0.1.2.3.4.5.6.7",
            "type": {
                "coding": [
                    {
                        "code": "MR3",
                        "system": "mysystem3"
                    },
                    {
                        "code": "MR4",
                        "system": "mysystem4"
                    }
                ]
            },
            "value": "4444444"
        }
    ]

Here's what the extracted parameters look like in the x_TOKEN_VALUES_V views.

PARAMETER_NAME_ID CODE_SYSTEM_ID TOKEN_VALUE COMPOSITE_ID
1191 20003 333333
20000 20005 MR1 0
20001 20010 333333 0
20000 20004 MR2 1
20001 20010 333333 1
1191 20003 4444444
20000 20009 MR3 2
20001 20010 4444444 2
20000 20008 MR4 3
20001 20010 4444444 3

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste tbieste changed the title Issue #1323 - Extract :of-type parameter as internal composite Issue #1323 - Add support for ':of-type' modifier Mar 19, 2021
@tbieste
Copy link
Contributor Author

tbieste commented Mar 19, 2021

This PR is dependent on changes in the PR for issue #773.
So review of this PR can focus on just the commits for this issue #1323.

@tbieste tbieste marked this pull request as ready for review March 19, 2021 22:03
@lmsurpre
Copy link
Member

This PR is dependent on changes in the PR for issue #773.
So review of this PR can focus on just the commits for this issue #1323.

Tip: you can actually have this pull request target the branch you used for the other PR...then the diff will only show the delta. If the other PR gets merged, github will automatically change this target to main. Mind if I change the base of the PR?

@tbieste
Copy link
Contributor Author

tbieste commented Mar 22, 2021

This PR is dependent on changes in the PR for issue #773.
So review of this PR can focus on just the commits for this issue #1323.

Tip: you can actually have this pull request target the branch you used for the other PR...then the diff will only show the delta. If the other PR gets merged, github will automatically change this target to main. Mind if I change the base of the PR?

Ah, ok. I didn't realize it worked that way. Sure, go ahead!

@tbieste tbieste changed the base branch from main to tbieste-issue-773 March 22, 2021 13:58
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Base automatically changed from tbieste-issue-773 to main March 22, 2021 16:32
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the tests pass)

@tbieste tbieste merged commit 23046b7 into main Mar 22, 2021
@tbieste tbieste deleted the tbieste-issue-1323 branch March 22, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants