Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2207 - consistently throw FHIRPatchException for bad patches #2210

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

lmsurpre
Copy link
Member

@lmsurpre lmsurpre commented Apr 7, 2021

Previously, which exception you got was dependent on what was wrong with
the patch.

And prior to the model changes for this same issue, we actually allowed
invalid patches to be applied (in the case of adding, inserting, and
replacing on a list).

Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com

@lmsurpre lmsurpre requested a review from JohnTimm April 7, 2021 03:20
@lmsurpre lmsurpre force-pushed the issue-2207-b branch 6 times, most recently from f27b446 to dba846a Compare April 7, 2021 13:05
@lmsurpre lmsurpre force-pushed the issue-2207 branch 2 times, most recently from a0d2fb3 to 5c3c7d8 Compare April 7, 2021 13:27
Copy link
Collaborator

@JohnTimm JohnTimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming that the changes to model classes work themselves out once the other PR is merged)

Previously, which exception you got was dependent on what was wrong with
the patch.

And prior to the model changes for this same issue, we actually allowed
invalid patches to be applied (in the case of adding, inserting, and
replacing on a list).

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Base automatically changed from issue-2207 to main April 7, 2021 14:31
@JohnTimm JohnTimm merged commit 83d6560 into main Apr 7, 2021
@JohnTimm JohnTimm deleted the issue-2207-b branch April 7, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants