Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2377 - update ConstraintGenerator #2389

Merged
merged 3 commits into from
May 19, 2021
Merged

Issue #2377 - update ConstraintGenerator #2389

merged 3 commits into from
May 19, 2021

Conversation

JohnTimm
Copy link
Collaborator

@JohnTimm JohnTimm commented May 19, 2021

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

Changes made:

  • Updated ConstraintGenerator.generatePatternValueConstraint to support the pattern value constraints that are also slices with a discriminator path of $this
  • Updated FHIRPathEvaluator to remove "workaround" for in operator. Previously we turned an in operator expression into a memberOf function invocation in some circumstances.
  • disabled test in MemberOfFunctionTest
  • added unit test using latest version of C4BB Patient structure definition

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested review from prb112 and lmsurpre May 19, 2021 19:37
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - based on our discussion and screen share this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants