Vanity URLs with AWS result in bucket NOT_FOUND on #2411 #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre
reviewed
May 24, 2021
fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/provider/impl/S3Provider.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
May 24, 2021
fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/provider/impl/S3Provider.java
Outdated
Show resolved
Hide resolved
…der/impl/S3Provider.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
commented
May 26, 2021
fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/provider/impl/S3Provider.java
Outdated
Show resolved
Hide resolved
…der/impl/S3Provider.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112
commented
May 26, 2021
fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/provider/impl/S3Provider.java
Outdated
Show resolved
Hide resolved
…der/impl/S3Provider.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
lmsurpre
approved these changes
May 26, 2021
There was a problem hiding this comment.
Paul informed me that the system will still generate a reasonable error message for cases where the bucket doesn't actually exist, so I'm marking this LGTM.
However, I'd still like to better understand why the S3 SDK doesn't work with the bucket "vanity url" when the other methods do. I wonder if its worth opening on stack overflow (or similar)...
lmsurpre
reviewed
May 26, 2021
fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/provider/impl/S3Provider.java
Show resolved
Hide resolved
prb112
commented
May 27, 2021
fhir-bulkdata-webapp/src/main/java/com/ibm/fhir/bulkdata/provider/impl/S3Provider.java
Show resolved
Hide resolved
…der/impl/S3Provider.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
pushed a commit
that referenced
this pull request
Jun 9, 2021
Vanity URLs with AWS result in bucket NOT_FOUND on #2411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Bastide pbastide@us.ibm.com