Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2296, Issue #2377 - miscellaneous FHIRPath updates #2418

Merged
merged 1 commit into from
May 24, 2021

Conversation

JohnTimm
Copy link
Collaborator

Miscellaneous Updates

  • Fold resolveRelativeReferences into the EvaluationContext class. Typically FHIRPath "external constants" are treated as data. In this case, however, we are using an external constant as configuration parameter. It makes more sense to make this a field in the EvaluationContext class itself.
  • Created hasResourceAssertedProfile method in ProfileSupport
  • Added validation logic to the FHIRPathUtil.compile method to prevent partial expressions from being evaluated without throwing an exception

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from prb112 May 24, 2021 14:10
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnTimm JohnTimm merged commit a6a8308 into main May 24, 2021
@JohnTimm JohnTimm deleted the johntimm-main branch May 24, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants