fhir-notification: Limit handling for 1M #1948 #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated fhir server's users guide to outline new preferences and add missing fields - Updated FHIRNotificationUtil to support new max Size behavior and bytes so that it can be tuned to each use case by subset or omit when it hits a limit. (There is no spanning/splitting to avoid delivery order issues) - Add Synchronous support to Kafka Notification and documentation how to enable (users can now chose if they want a lossy approach or not) - Add test coverage for fhir-notification and FHIRNotificationUtil Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
reviewed
Jun 15, 2021
fhir-notification/src/main/java/com/ibm/fhir/notification/util/FHIRNotificationUtil.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/com/ibm/fhir/notifications/kafka/impl/FHIRNotificationKafkaPublisher.java
Outdated
Show resolved
Hide resolved
...afka/src/main/java/com/ibm/fhir/notifications/kafka/impl/FHIRNotificationKafkaPublisher.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 15, 2021
...afka/src/main/java/com/ibm/fhir/notifications/kafka/impl/FHIRNotificationKafkaPublisher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
reviewed
Jun 16, 2021
...afka/src/main/java/com/ibm/fhir/notifications/kafka/impl/FHIRNotificationKafkaPublisher.java
Outdated
Show resolved
Hide resolved
prb112
commented
Jun 16, 2021
...afka/src/main/java/com/ibm/fhir/notifications/kafka/impl/FHIRNotificationKafkaPublisher.java
Outdated
Show resolved
Hide resolved
…r/notifications/kafka/impl/FHIRNotificationKafkaPublisher.java Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing fields
bytes so that it can be tuned to each use case by subset or omit when it
hits a limit. (There is no spanning/splitting to avoid delivery order
issues)
enable (users can now chose if they want a lossy approach or not)
Signed-off-by: Paul Bastide pbastide@us.ibm.com