Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1822 - Add Vacuum Setting support for PostgreSQL #2628

Merged
merged 7 commits into from
Jul 21, 2021
Merged

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Jul 20, 2021

Add Vacuum Setting support for PostgreSQL

  • Add V0017 to indicate Schema change
  • Introduce WITH to the Java data model
  • Update the Adapters to support WITH
  • Add PostgresVacuumSettingDAO controls the setting of the default scale factor, the threshold and the limit per https://ibm.github.io/FHIR/guides/FHIRPerformanceGuide/#412-tuning-auto-vacuum
  • Add to the Data Definition in the schema generator
  • Add a Helper Method/new command --update-vacuum to update the current vacuum settings to a specific setting.

To check SQL settings:

select relname, (reloptions)::VARCHAR
from pg_class
join pg_namespace on pg_namespace.oid = pg_class.relnamespace
where relname = LOWER('STRUCTUREMAP_LOGICAL_RESOURCES')
and pg_namespace.nspname = LOWER('TEST12345');

Signed-off-by: Paul Bastide pbastide@us.ibm.com

- USCoreConditionTest - Clean up logging
- PlanDefinitionApply - Clean up logging

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
- Add V0017 to indicate Schema change
- Introduce WITH to the Java data model
- Update the Adapters to support WITH
- Add PostgresVacuumSettingDAO controls the setting of the default scale
factor, the threshold and the limit per
https://ibm.github.io/FHIR/guides/FHIRPerformanceGuide/#412-tuning-auto-vacuum
- Add to the Data Definition in the schema generator
- Add a Helper Method/new command --update-vacuum to update the current
vacuum settings to a specific setting.

To check SQL:
select relname, (reloptions)::VARCHAR
from pg_class
join pg_namespace on pg_namespace.oid = pg_class.relnamespace
where relname = LOWER('STRUCTUREMAP_LOGICAL_RESOURCES')
and pg_namespace.nspname = LOWER('TEST12345');

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one minor comment

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 merged commit 5498e59 into main Jul 21, 2021
@prb112 prb112 deleted the issue-1822 branch July 21, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants