-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1822 - Add Vacuum Setting support for PostgreSQL #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- USCoreConditionTest - Clean up logging - PlanDefinitionApply - Clean up logging Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
- Add V0017 to indicate Schema change - Introduce WITH to the Java data model - Update the Adapters to support WITH - Add PostgresVacuumSettingDAO controls the setting of the default scale factor, the threshold and the limit per https://ibm.github.io/FHIR/guides/FHIRPerformanceGuide/#412-tuning-auto-vacuum - Add to the Data Definition in the schema generator - Add a Helper Method/new command --update-vacuum to update the current vacuum settings to a specific setting. To check SQL: select relname, (reloptions)::VARCHAR from pg_class join pg_namespace on pg_namespace.oid = pg_class.relnamespace where relname = LOWER('STRUCTUREMAP_LOGICAL_RESOURCES') and pg_namespace.nspname = LOWER('TEST12345'); Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112
requested review from
lmsurpre,
punktilious,
JohnTimm,
tbieste and
michaelwschroeder
July 20, 2021 15:13
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste
reviewed
Jul 20, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/derby/DerbyAdapter.java
Show resolved
Hide resolved
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/db2/Db2Adapter.java
Show resolved
Hide resolved
.../src/main/java/com/ibm/fhir/database/utils/postgres/VacuumSettingsTableDataModelVisitor.java
Show resolved
Hide resolved
fhir-server-test/src/test/java/com/ibm/fhir/server/test/profiles/USCoreConditionTest.java
Show resolved
Hide resolved
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/common/CommonDatabaseAdapter.java
Show resolved
Hide resolved
...abase-utils/src/main/java/com/ibm/fhir/database/utils/postgres/PostgresVacuumSettingDAO.java
Outdated
Show resolved
Hide resolved
fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/control/FhirResourceTableGroup.java
Outdated
Show resolved
Hide resolved
fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/control/FhirSchemaGenerator.java
Outdated
Show resolved
Hide resolved
fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/control/FhirSchemaGenerator.java
Outdated
Show resolved
Hide resolved
fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/control/FhirSchemaGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
michaelwschroeder
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one minor comment
...abase-utils/src/main/java/com/ibm/fhir/database/utils/postgres/PostgresVacuumSettingDAO.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Vacuum Setting support for PostgreSQL
To check SQL settings:
Signed-off-by: Paul Bastide pbastide@us.ibm.com