Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportPartitionAnalyzer not reporting infly rate on threshold #3000 #3358

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Feb 16, 2022

ImportPartitionAnalyzer - modify the infly rate reporting message and changed the message to report out Resources/second and report which workitem is triggering the message.
Improve accuracy of the infly rate calculation

Sample Message:

[INFO ] Import in-fly rate:
        [286/286/r4_AllergyIntolerance.ndjson/AllergyIntolerance]
        reportingThreshold=[2000] resources imported in 12610 milliseconds,
        ImportRate: [0.064] Resources/milliseconds
            Instance/Execution/File/ResourceType threshold milliseconds and
            rate.

Signed-off-by: Paul Bastide pbastide@us.ibm.com

#3000

    ImportPartitionAnalyzer - modify the infly rate reporting message and
    changed the message to report out Resources/second and report which
    workitem is triggering the message.
        Improve accuracy of the infly rate calculation
        Sample Message: [INFO ] Import in-fly rate:
        [286/286/r4_AllergyIntolerance.ndjson/AllergyIntolerance]
        reportingThreshold=[2000] resources imported in 12610 milliseconds,
        ImportRate: [0.064] Resources/milliseconds
            Instance/Execution/File/ResourceType threshold milliseconds and
            rate.

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 requested a review from lmsurpre February 16, 2022 17:57
@prb112 prb112 self-assigned this Feb 16, 2022
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I totally get it, but the changes look ok to me

@lmsurpre lmsurpre merged commit 6a0e929 into main Feb 16, 2022
@lmsurpre lmsurpre deleted the issue-3000 branch February 16, 2022 22:41
@prb112
Copy link
Contributor Author

prb112 commented Feb 17, 2022

Since it was so quick it was actually rounding to zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants