Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #3256 added unit tests to support QA of FHIRClient default mime… #3876

Merged
merged 1 commit into from
Aug 12, 2022
Merged

issue #3256 added unit tests to support QA of FHIRClient default mime… #3876

merged 1 commit into from
Aug 12, 2022

Conversation

punktilious
Copy link
Collaborator

@punktilious punktilious commented Aug 12, 2022 •
edited
Loading

…type

The two new unit tests check:

  1. Using the default FHIRClient configuration, interactions related to an R4B resource type (Ingredient) are successful.
  2. When overriding the mime type property to remove fhirVersion, interactions related to an R4B resource type are unsuccessful.

Signed-off-by: Robin Arnold robin.arnold@ibm.com

@punktilious
issue #3256 added unit tests to support QA of FHIRClient default mime…
b457515 
…type

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious punktilious mentioned this pull request Aug 12, 2022
Merged
lmsurpre
lmsurpre approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a hint/suggestion for what I find to be a cleaner way to create the minimal test resource, but probably fine either way.

@lmsurpre lmsurpre merged commit 8142d88 into main Aug 12, 2022
@lmsurpre lmsurpre deleted the issue-3256-qa branch August 12, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punktilious @lmsurpre