Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Support multiple networks with one installation #398

Closed
Isabello opened this issue Jan 19, 2017 · 4 comments
Closed

Support multiple networks with one installation #398

Isabello opened this issue Jan 19, 2017 · 4 comments

Comments

@Isabello
Copy link
Contributor

Isabello commented Jan 19, 2017

In our current implementation various files are required to be modified to change what network is able to be used.

These files are:

helpers/constants.js
helpers/exceptions.js
config.json
genesisBlock.json

The goal of this change is to simplify the use:

  • the ease of running a node from source with any network from a single command, like node app --mainnet
  • clarity of network - specific variables
  • decreasing risk of making mistake while merging network specific files during releases
@karmacoma karmacoma changed the title Supporting multiple networks with one installation Support multiple networks with one installation Feb 1, 2018
@MaciejBaj
Copy link
Contributor

After 1.0.0 the list of "network-dependant files" shapes as follows:

  • config.json
  • genesis_block.json
  • helpers/exceptions.js
  • helpers/constants.js
  • scripts/update_config.js

Keeping them on one branch would decrease possible confusion and risk connected with working and releasing next versions on different networks:

  • Alphanet (Devnet),
  • Betanet,
  • Testnet,
  • Mainnet.

Each change to "network-dependant file" would have to added to:

  • feature branch (like 1.0.0-beta.9.0).

@Isabello
Copy link
Contributor Author

Isabello commented Jun 15, 2018 via email

@nazarhussain
Copy link
Contributor

@MaciejBaj Question, we will keep configuration files for different networks in source. Do you also want to keep those in compile builds? So one build can also be used for different networks? My suggestion would be to do it.

@diego-G
Copy link

diego-G commented Jun 21, 2018

Please guys, don't forget helpers/milestones.js and genesis_delegates.js when applies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants