Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling cosine distance from DeezyMatch to speed up retrieval #156

Closed
mcollardanuy opened this issue Sep 2, 2022 · 0 comments · Fixed by #138 or #160
Closed

Allow disabling cosine distance from DeezyMatch to speed up retrieval #156

mcollardanuy opened this issue Sep 2, 2022 · 0 comments · Fixed by #138 or #160

Comments

@mcollardanuy
Copy link
Collaborator

DeezyMatch issue: Living-with-machines/DeezyMatch#131

Cosine distance is always computed. If we're using faiss, we don't need to compute cosine distance, and would probably speed up candidate selection considerably.

The only thing we need to take into account is that we'll need the score we return in candidate ranking (ranking.py), because we use "cosine_dist", and we'd need to use "faiss" instead.

@mcollardanuy mcollardanuy self-assigned this Sep 2, 2022
@mcollardanuy mcollardanuy added enhancement New feature or request candidate selection at scale and removed enhancement New feature or request labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant