Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

fix: update requirements to support arm based macOS #251

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 15, 2024

Description

PyYAML requires Cython to install on arm64 macOS runners.

See: yaml/pyyaml#724 (comment)

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (6d1f8d8) to head (4b715dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files          24       24           
  Lines        2907     2907           
=======================================
  Hits         2340     2340           
  Misses        567      567           
Flag Coverage Δ
Python-2.7-Linux 78.77% <ø> (ø)
Python-2.7-Windows 78.77% <ø> (ø)
Python-2.7-macOS 78.77% <ø> (?)
Python-3.10-Linux 80.35% <ø> (ø)
Python-3.10-Windows 80.35% <ø> (ø)
Python-3.10-macOS 80.35% <ø> (ø)
Python-3.11-Linux 80.35% <ø> (ø)
Python-3.11-Windows 80.35% <ø> (ø)
Python-3.11-macOS 80.35% <ø> (ø)
Python-3.8-Linux 80.24% <ø> (ø)
Python-3.8-Windows 80.24% <ø> (ø)
Python-3.8-macOS 80.24% <ø> (ø)
Python-3.9-Linux 80.30% <ø> (ø)
Python-3.9-Windows 80.30% <ø> (ø)
Python-3.9-macOS 80.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the fix-update-requirements-to-support-arm-based-macOS branch 6 times, most recently from 739e7f4 to 6e672fc Compare May 15, 2024 02:29
@ReenigneArcher ReenigneArcher force-pushed the fix-update-requirements-to-support-arm-based-macOS branch from 6e672fc to 4b715dd Compare May 15, 2024 23:27
@ReenigneArcher ReenigneArcher merged commit 3815503 into master May 15, 2024
30 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-update-requirements-to-support-arm-based-macOS branch May 15, 2024 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant