-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control Center: Add missing Options, and Fix some #1347
base: master
Are you sure you want to change the base?
Conversation
- Added new options for AccessibilityShortcuts, Battery (enum mode), Hearing, KeyboardBrightness, MusicRecognition, and updated UserSwitcher. - Updated existing options (Display, FocusModes, NowPlaying, ScreenMirroring, Sound) to use enum types with refined mapping values.
I just have doubt about the options that change their type, I know there are ways, but here I'm not sure how to add a warning or heads up, to indicate the allowed values had changed |
9ed9dd6
to
bf0b436
Compare
bf0b436
to
2362651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on the options ;)
For the type change, we could have backward compatibility with warning by adding true
& false
in the mkXXXXApply
mapping functions like:
mkEnumApply {
always = 21,
hide = 42,
true = lib.warn ''something something use "always" now'' 21,
false = lib.warn ''something something use `"hide"` now'' 42,
}
ae9a1fa
to
969cca6
Compare
969cca6
to
f88f0a1
Compare
No description provided.