Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When credit card error, the cart view shows prices like '$#Price:0x00007f9e2c023f88' #3465

Open
rbarreca opened this issue Sep 20, 2018 · 2 comments

Comments

@rbarreca
Copy link
Contributor

Actual

  1. Put in junk credit card
  2. Place order
  3. When you see error validation message, prices look like '$#Price:0x00007f9e2c023f88'
@rbarreca
Copy link
Contributor Author

Tested on staging and works as advertised: proper read-only label shows up.

Thought, it would be better if the error sent you back to the /cart view where you actually see text inputs to change product quantities. But, that will be left for later.

@rbarreca
Copy link
Contributor Author

@thermistor actually it looks like this critically broke order checkout. :( While testing on staging and placing an order for Ohio Valley Food Connection via Purchase Order I got this error: https://rollbar.com/LocalOrbit/Local-Orbit/items/575/?item_page=0&item_count=100&#traceback

We really need to get tests green. Something as basic as placing a successful order needs to be caught before a PR goes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant