Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sbt plugins #24

Closed
wants to merge 1 commit into from
Closed

update sbt plugins #24

wants to merge 1 commit into from

Conversation

xuwei-k
Copy link

@xuwei-k xuwei-k commented Jun 11, 2018

No description provided.

@sarahgerweck
Copy link
Contributor

@xuwei-k is there any particular motivation for this PR?

@sarahgerweck
Copy link
Contributor

sarahgerweck commented Jun 13, 2018

Based on your blog, I believe this PR, which requires me to do all the testing since it changes publish-to-Sonatype plugins, is an attempt to game GitHub statistics so you appear to be a contributor to projects where you didn't contribute anything material. If you can convince me otherwise, I'll happily accept your changes; otherwise please don't submit any more PRs like this.

@eed3si9n
Copy link

eed3si9n commented Jun 17, 2018

Based on your blog, I believe this PR, which requires me to do all the testing since it changes publish-to-Sonatype plugins, is an attempt to game GitHub statistics so you appear to be a contributor to projects where you didn't contribute anything material.

It's ultimately up to project maintainers to accept or reject contributions because it doesn't come with tests or disagreements etc, but I think this is an unfair characterization of Yoshida-san's PR.

MiMa bump normally doesn't require additional work, but it often is finding corner cases of binary incompatibility. In this case 0.2.0 should bring the fix for lightbend-labs/mima#196. sbt-pgp 1.1.1 brings in sbt/sbt-pgp#121.

Also it's fairly common for contributors to first make superficial changes before they get into more meatier stuff. He does a lot for the community, so I had to say something.

@sarahgerweck
Copy link
Contributor

Thanks @eed3si9n: I appreciate the data point. As I said in my previous comment, I have no intention to discourage people from helping, but this no-description PR felt weird, and seemed to be part of a pattern. If I'm wrong, then @xuwei-k like I said initially please feel free to make contributions.

@xuwei-k xuwei-k deleted the update-plugins branch July 10, 2018 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants