Fix regular expression to find root directory in make/bootstrap.lua #943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a posix path like
/a/b//c
, the regex pattern to find root directory won't match anything and cause server crashing even if the path is valid. I think windows path also has this problem.This will happen if someone add an environment path end with a separator.
This environment path will be used to extend to
package.cpath
. So,package.cpath
here is/path/to/lua-language-server/bin//?.so
which the current regex pattern can't recognize.