feat: D10 compatibility #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscano
commented
Oct 9, 2023
| * \DateTimeInterface and we want to return a ConcreteDateTime object instead. | ||
| * Unfortunately \DateTimeInterface can't be extended by user classes, so the | ||
| * option we have is to unfortunately copy here most methods from | ||
| * DateTimeNormalizer, and modify the ones that are particular to us here. |
There was a problem hiding this comment.
This is unfortunately the only way I could find to workaround the fact that we can't extend \DateTimeInterface but I would be happy to go into another direction if others can think of alternative approaches.
There was a problem hiding this comment.
Would it be possible to use a decorator pattern here? I think this is a perfect use case for it.
There was a problem hiding this comment.
Good call! I'll give it a try. Thanks!
e0ipso
reviewed
Oct 9, 2023
e0ipso
reviewed
Oct 9, 2023
e0ipso
reviewed
Oct 9, 2023
e0ipso
reviewed
Oct 10, 2023
|
|
||
| public function getSupportedTypes(?string $format): array | ||
| { | ||
| return self::$supportedTypes; |
There was a problem hiding this comment.
Ugh! If you don't override here it won't work due to late static binding, right? I wish the decorated used static instead of self.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's create a new major bumping all dependencies to be D10-only.