Feature/Update Minimum Supported Version to Ubuntu 18 (smartdevicelin…

…k#3727)

* Remove references to ubuntu 16 in documentation

* Remove older ssl ciphers from crypto manager

* Fix style

* Change logs for unsupported protocols

* Update clang-format version to 8 and re-run style script

* Apply suggestions from code review

Co-authored-by: Collin <iCollin@users.noreply.github.com>

* Drop support for openssl 1.0

* Remove some references to OPENSSL_1_1_VERSION

Co-authored-by: Collin <iCollin@users.noreply.github.com>

.github/CONTRIBUTING.md

@@ -4,7 +4,6 @@ Third party contributions are essential for making SDL great. However, we do hav
 
 ## Environment
 Currently supported:
-* Ubuntu Linux 16.04 with GCC 5.4.x
 * Ubuntu Linux 18.04 with GCC 7.3.x
 * Ubuntu Linux 20.04 with GCC 9.3.x
 * [C++11 standard](https://github.com/smartdevicelink/sdl_evolution/issues/132)

.github/workflows/sdl_core_github_ci.yml

@@ -9,7 +9,7 @@ jobs:
       run: git -C ${{ github.workspace }} submodule update --init --recursive
     # Install Dependencies
     - name: Apt Get Dependencies
-      run: sudo apt-get update && sudo apt-get install libssl-dev libbluetooth3 libbluetooth-dev libudev-dev cmake html2text lcov git cmake automake1.11 build-essential libavahi-client-dev sqlite3 libsqlite3-dev libgtest-dev bluez-tools libpulse-dev libusb-1.0.0-dev cppcheck python3-pip python3-setuptools && sudo apt-get install -f clang-format-6.0
+      run: sudo apt-get update && sudo apt-get install libssl-dev libbluetooth3 libbluetooth-dev libudev-dev cmake html2text lcov git cmake automake1.11 build-essential libavahi-client-dev sqlite3 libsqlite3-dev libgtest-dev bluez-tools libpulse-dev libusb-1.0.0-dev cppcheck python3-pip python3-setuptools && sudo apt-get install -f clang-format-8
     - name: Setup CMAKE
       uses: jwlawson/actions-setup-cmake@v1.8
       with:

README.md

@@ -20,7 +20,6 @@ Pull Requests Welcome!
 
 ## Environment
 Currently supported:
-* Ubuntu Linux 16.04 with GCC 5.4.x
 * Ubuntu Linux 18.04 with GCC 7.5.x
 * Ubuntu Linux 20.04 with GCC 9.3.x
 * [C++11 standard](https://github.com/smartdevicelink/sdl_evolution/issues/132)

src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_command_factory.cc

@@ -217,7 +217,8 @@ CommandCreator& RCCommandFactory::get_mobile_command_creator(
                  : rc_factory.GetCreator<
                        commands::GetInteriorVehicleDataConsentResponse>();
     }
-    default: {}
+    default: {
+    }
   }
   return rc_factory.GetCreator<RCInvalidCommand>();
 }
@@ -230,7 +231,8 @@ CommandCreator& RCCommandFactory::get_mobile_notification_creator(
       return rc_factory
           .GetCreator<commands::OnInteriorVehicleDataNotification>();
     }
-    default: {}
+    default: {
+    }
   }
   return rc_factory.GetCreator<RCInvalidCommand>();
 }
@@ -259,7 +261,8 @@ CommandCreator& RCCommandFactory::get_mobile_creator_factory(
       }
       break;
     }
-    default: {}
+    default: {
+    }
   }
   return rc_factory.GetCreator<RCInvalidCommand>();
 }
@@ -314,7 +317,9 @@ CommandCreator& RCCommandFactory::get_hmi_creator_factory(
                  : rc_factory
                        .GetCreator<commands::RCSetGlobalPropertiesResponse>();
     }
-    default: { return rc_factory.GetCreator<RCInvalidCommand>(); }
+    default: {
+      return rc_factory.GetCreator<RCInvalidCommand>();
+    }
   }
 }
 }  // namespace rc_rpc_plugin

src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc

@@ -140,7 +140,9 @@ AcquireResult::eType ResourceAllocationManagerImpl::AcquireResource(
                     << module_type << " " << module_id);
       return AcquireResult::ALLOWED;
     }
-    default: { DCHECK_OR_RETURN(false, AcquireResult::IN_USE); }
+    default: {
+      DCHECK_OR_RETURN(false, AcquireResult::IN_USE);
+    }
   }
 }
 

src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_bc_system_capability_updated_notification_from_hmi.cc

@@ -191,7 +191,9 @@ void OnBCSystemCapabilityUpdatedNotificationFromHMI::Run() {
       RemoveAppIdFromNotification();
       break;
     }
-    default: { SDL_LOG_ERROR("Unknown system capability type received"); }
+    default: {
+      SDL_LOG_ERROR("Unknown system capability type received");
+    }
   }
 
   SendNotificationToMobile(message_);

src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_capability_updated_notification.cc

@@ -239,7 +239,9 @@ void OnSystemCapabilityUpdatedNotification::Run() {
         msg_params[strings::system_capability][strings::display_capabilities] =
             *capabilities;
       } break;
-      default: { SDL_LOG_ERROR("Unknown system capability type"); }
+      default: {
+        SDL_LOG_ERROR("Unknown system capability type");
+      }
     }
 
     SDL_LOG_INFO("Sending OnSystemCapabilityUpdated " << capability_type_string

src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/register_app_interface_request.cc

@@ -224,7 +224,8 @@ void RegisterAppInterfaceRequest::FillApplicationParams(
           application->set_webengine_projection_enabled(true);
           break;
         }
-        default: {}
+        default: {
+        }
       }
     }
   }

src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/hmi_command_factory.cc

@@ -947,7 +947,9 @@ CommandCreator& HMICommandFactory::get_creator_factory(
       return factory
           .GetCreator<commands::BCOnAppCapabilityUpdatedNotification>();
     }
-    default: { return factory.GetCreator<InvalidCommand>(); }
+    default: {
+      return factory.GetCreator<InvalidCommand>();
+    }
   }
 }
 

src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc

@@ -408,7 +408,8 @@ CommandCreator& MobileCommandFactory::get_command_creator(
       using app_mngr::commands::Command;
       return factory.GetCreator<commands::GenericResponse>();
     }
-    default: {}
+    default: {
+    }
   }
   return factory.GetCreator<InvalidCommand>();
 }
@@ -480,7 +481,8 @@ CommandCreator& MobileCommandFactory::get_notification_creator(
     case mobile_apis::FunctionID::OnSubtleAlertPressedID: {
       return factory.GetCreator<commands::OnSubtleAlertPressedNotification>();
     }
-    default: {}
+    default: {
+    }
   }
   return factory.GetCreator<InvalidCommand>();
 }
@@ -501,7 +503,8 @@ CommandCreator& MobileCommandFactory::get_notification_from_mobile_creator(
       return factory
           .GetCreator<commands::mobile::OnAppCapabilityUpdatedNotification>();
     }
-    default: {}
+    default: {
+    }
   }
   return factory.GetCreator<InvalidCommand>();
 }
@@ -532,7 +535,8 @@ CommandCreator& MobileCommandFactory::get_creator_factory(
       }
       break;
     }
-    default: {}
+    default: {
+    }
   }
   CommandCreatorFactory factory(
       application_manager_, rpc_service_, hmi_capabilities_, policy_handler_);

src/components/application_manager/rpc_plugins/vehicle_info_plugin/src/vehicle_info_mobile_command_factory.cc

@@ -208,7 +208,8 @@ app_mngr::CommandCreator& VehicleInfoMobileCommandFactory::get_command_creator(
                  ? factory.GetCreator<commands::DiagnosticMessageRequest>()
                  : factory.GetCreator<commands::DiagnosticMessageResponse>();
     }
-    default: {}
+    default: {
+    }
   }
   return factory.GetCreator<VehicleInfoInvalidCommand>();
 }
@@ -226,7 +227,8 @@ VehicleInfoMobileCommandFactory::get_notification_creator(
     case mobile_apis::FunctionID::OnVehicleDataID: {
       return factory.GetCreator<commands::OnVehicleDataNotification>();
     }
-    default: {}
+    default: {
+    }
   }
   return factory.GetCreator<VehicleInfoInvalidCommand>();
 }
@@ -254,7 +256,8 @@ app_mngr::CommandCreator& VehicleInfoMobileCommandFactory::get_creator_factory(
       }
       break;
     }
-    default: {}
+    default: {
+    }
   }
   VehicleInfoCommandParams params = {application_manager_,
                                      rpc_service_,

src/components/application_manager/src/commands/command_impl.cc

@@ -450,7 +450,9 @@ bool CommandImpl::ReplaceMobileWithHMIAppId(
         }
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
   }
 
@@ -499,7 +501,9 @@ bool CommandImpl::ReplaceHMIWithMobileAppId(
         }
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
   }
 

src/components/application_manager/src/help_prompt_manager_impl.cc

@@ -369,7 +369,9 @@ void HelpPromptManagerImpl::SetSendingType(
         }
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
     SDL_LOG_DEBUG(
         "Sending type set to:" << static_cast<uint32_t>(sending_type_));

src/components/application_manager/src/message_helper/message_helper.cc

@@ -3408,7 +3408,9 @@ mobile_apis::Result::eType MessageHelper::ProcessSoftButtons(
         }
         break;
       }
-      default: { continue; }
+      default: {
+        continue;
+      }
     }
 
     soft_buttons[j++] = request_soft_buttons[i];

src/components/application_manager/src/policies/policy_event_observer.cc

@@ -70,7 +70,9 @@ void PolicyEventObserver::on_event(const event_engine::Event& event) {
       unsubscribe_from_event(hmi_apis::FunctionID::VehicleInfo_GetVehicleData);
       break;
     }
-    default: { break; }
+    default: {
+      break;
+    }
   }
 }
 

src/components/application_manager/src/policies/policy_handler.cc

@@ -2014,7 +2014,9 @@ void PolicyHandler::AddStatisticsInfo(int type) {
       ++count_of_iap_buffer_full;
       break;
     }
-    default: { SDL_LOG_WARN("Type of statistics is unknown"); }
+    default: {
+      SDL_LOG_WARN("Type of statistics is unknown");
+    }
   }
 }
 
@@ -2033,7 +2035,9 @@ void PolicyHandler::OnSystemError(int code) {
       ++count_sync_out_of_memory;
       break;
     }
-    default: { SDL_LOG_WARN("System error is unknown"); }
+    default: {
+      SDL_LOG_WARN("System error is unknown");
+    }
   }
 }
 

src/components/application_manager/test/state_controller/state_controller_test.cc

@@ -437,7 +437,9 @@ class StateControllerImplTest : public ::testing::Test {
                            SystemContext::SYSCTXT_MAIN));
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
   }
 
@@ -491,7 +493,9 @@ class StateControllerImplTest : public ::testing::Test {
         PrepareStateResultsForAttenuated(result_hmi_state);
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
   }
 
@@ -548,7 +552,9 @@ class StateControllerImplTest : public ::testing::Test {
         PrepareStateResultsForAttenuated(result_hmi_state);
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
   }
 
@@ -579,7 +585,9 @@ class StateControllerImplTest : public ::testing::Test {
         PrepareStateResultsForAttenuated(result_hmi_state);
         break;
       }
-      default: { break; }
+      default: {
+        break;
+      }
     }
   }
 

src/components/policy/policy_external/src/policy_table/types.cc

@@ -19,7 +19,9 @@ std::string PolicyTableTypeToString(const PolicyTableType pt_type) {
     case PT_SNAPSHOT: {
       return "PT_SNAPSHOT";
     }
-    default: { return "INVALID_PT_TYPE"; }
+    default: {
+      return "INVALID_PT_TYPE";
+    }
   }
 }
 

src/components/policy/policy_regular/src/policy_table/types.cc

@@ -19,7 +19,9 @@ std::string PolicyTableTypeToString(const PolicyTableType pt_type) {
     case PT_SNAPSHOT: {
       return "PT_SNAPSHOT";
     }
-    default: { return "INVALID_PT_TYPE"; }
+    default: {
+      return "INVALID_PT_TYPE";
+    }
   }
 }
 

src/components/protocol_handler/src/service_status_update_handler.cc

@@ -19,7 +19,9 @@ hmi_apis::Common_ServiceType::eType GetHMIServiceType(
     case SERVICE_TYPE_NAVI: {
       return Common_ServiceType::VIDEO;
     }
-    default: { return Common_ServiceType::INVALID_ENUM; }
+    default: {
+      return Common_ServiceType::INVALID_ENUM;
+    }
   }
 }
 

src/components/protocol_handler/test/service_status_update_handler_test.cc

@@ -87,7 +87,9 @@ class ServiceStatusUpdateHandlerTest
       case ServiceStatus::PROTECTION_ENFORCED: {
         return Common_ServiceEvent::REQUEST_REJECTED;
       }
-      default: { return Common_ServiceEvent::INVALID_ENUM; }
+      default: {
+        return Common_ServiceEvent::INVALID_ENUM;
+      }
     }
   }