[SDL-0189] Fix onResetTimeout twice notification #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychernysheva
approved these changes
Jun 9, 2021
VladSemenyuk
approved these changes
Jun 9, 2021
VadymLuchko
force-pushed
the
fix/OnResetTimeout_Notification
branch
from
f7748a5 to
f8c8a3c
Compare
VadymLuchko
changed the title
VadymLuchko
force-pushed
the
fix/OnResetTimeout_Notification
branch
from
f8c8a3c to
970427a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[FORDTCN-2944]
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
ATF test scripts
Summary
In case we changed the ResetTimeout for more than 10 seconds, we were unable to change it to a different value.
To fix this problem, we can update the ResetTimeout to the request with the corresponding hmi_correlation_id in RequestTimeoutHandlerImpl::on_event() method.
CLA