[SDL-0189] Restrict timeout for subtle alert with soft buttons #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychernysheva
requested review from
VladSemenyuk,
VadymLuchko and
RomanReznichenkoLuxoft
RomanReznichenkoLuxoft
approved these changes
Jun 10, 2021
VadymLuchko
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FORDTCN-12133
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF test script
Summary
There is a requirement for SDL for
AlertRPC to not apply timeout if request contains soft buttons. The same requirement should work forSubtleAlertRPC. So corresponding changes were added to CommandRequestImpl class to prevent adding such request to request map inside of RequestTimeoutHandler class.CLA