Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sdl 0269 new vehicle data climate data #7

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

KhrystynaDubovyk
Copy link

Expand VehicleDataType enum with new param
Add new struct ClimateData
Add climateData to SubscribeVehicleData, UnsubscribeVehicleData, GetVehicleData, OnVehicleData RPCs

Add new struct
Add  to SubscribeVehicleData, UnsubscribeVehicleData, GetVehicleData, OnVehicleData RPCs
@@ -889,6 +889,7 @@
|VEHICLEDATA_ELECTRONICPARKBRAKESTATUS|29||
|VEHICLEDATA_CLOUDAPPVEHICLEID|30| Parameter used by cloud apps or the policy server to identify a head unit|
|VEHICLEDATA_OEM_CUSTOM_DATA|31||
|VEHICLEDATA_CLIMATEDATA|32||

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhrystynaDubovyk please rebase the feature branch to the latest develop

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or make git reset --hard origin/develop
and then git cherry-pick 02e39eb

Copy link
Author

@KhrystynaDubovyk KhrystynaDubovyk Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LitvinenkoIra, thank you for review, the conflicts are resolved

Copy link

@LitvinenkoIra LitvinenkoIra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comments

KhrystynaDubovyk and others added 5 commits November 24, 2020 15:08
Co-authored-by: Ira Lytvynenko (GitHub) <ILytvynenko@luxoft.com>
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
Co-authored-by: Shobhit Adlakha <ShobhitAd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants