remove TimeseriesCollection #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kain88-de
force-pushed
the
remove-TimeSeries-correl
branch
4 times, most recently
from
d10e6fc to
cca7ff2
Compare
richardjgowers
requested changes
Jun 4, 2017
Member
richardjgowers
left a comment
richardjgowers
left a comment
There was a problem hiding this comment.
Looks good, I'm blocking so we don't accidentally merge before 0.17. (ie merging onto develop would stop a 0.16.x series release)
Member
Author
|
When would we do a 0.16.3 release possibly? |
Member
|
@kain88-de do you mean 16.2 or 16.3? We'd do a bugfix release if we got a few good fixes and 0.17 seemed a few weeks off still. |
Member
Author
|
Once we start the pytest transition we won't be able to release for a couple of weeks anyway. |
Member
Author
|
@richardjgowers This PR is currently a blocker for #1372. Personally I think it would be good if us devs use the new DCD reader for a while as on a dev version before we make a release. |
kain88-de
force-pushed
the
remove-TimeSeries-correl
branch
2 times, most recently
from
a7a6ec1 to
0cf8ee0
Compare
kain88-de
force-pushed
the
remove-TimeSeries-correl
branch
from
0cf8ee0 to
083f8ba
Compare
richardjgowers
approved these changes
Jun 24, 2017
jbarnoud
added a commit
that referenced
this pull request
Jun 24, 2017
The PR #1375 introduced a syntax error in MDAnalysis.__init__. This commit fixes the defective line.
kain88-de
pushed a commit
that referenced
this pull request
Jun 24, 2017
* Fix a syntax error in MDAnalysis.__init__ The PR #1375 introduced a syntax error in MDAnalysis.__init__. This commit fixes the defective line. * Remove deprecation test about Timeseries collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1373
Fixes #186
Changes made in this Pull Request:
PR Checklist