init ReporterMachine #103
Open
init ReporterMachine #103
+318
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flozender
commented
Dec 4, 2020
| @@ -180,7 +181,7 @@ export default class TestScheduler { | |||
| aggregatedResults.snapshot.filesRemoved) | |||
| ); | |||
| }; | |||
|
|
|||
| reporterService.send('START'); | |||
There was a problem hiding this comment.
@thegoleffect how can we await for the onRunStart functions to finish running as we do in the line below? (L#185)
cc: @victorphoenix3 @jcs98
There was a problem hiding this comment.
if you want to "wait", you should have the async method dispatch another event on completion that transitions to another state. Then, replace the await code with either
- code that listens on states & executes something locally
- code that registers a method to the context that will get executed if exists on completion/state transition
There was a problem hiding this comment.
Thanks, we were able to get it running!
Co-authored-by: Jainam Chirag Shah <jcshah98@gmail.com> Co-authored-by: Jayati Shrivastava <gaurijove@gmail.com>
Co-authored-by: Jainam Chirag Shah <jcshah98@gmail.com> Co-authored-by: Jayati Shrivastava <gaurijove@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the XState skeleton for the Reporter rework issue
Test plan