From ef042e08c29b9887d6c95aa9852a494c50eaf135 Mon Sep 17 00:00:00 2001
From: MVP-D77 <11912714@mail.sustech.edu.cn>
Date: Fri, 27 May 2022 19:07:09 +0800
Subject: [PATCH] Some suggestion and example to fix this bug by dramatically
 update the Height of list #8823

---
 .../jabref/gui/fieldeditors/LinkedFilesEditor.fxml    |  2 +-
 .../jabref/gui/fieldeditors/LinkedFilesEditor.java    | 11 ++++++++++-
 .../gui/fieldeditors/LinkedFilesEditorViewModel.java  |  3 ++-
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml
index 7d34c27164e..b933e0d13c7 100644
--- a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml
+++ b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml
@@ -9,7 +9,7 @@
 <?import org.jabref.gui.icon.JabRefIconView?>
 <fx:root xmlns:fx="http://javafx.com/fxml/1" type="HBox" xmlns="http://javafx.com/javafx/8.0.112"
          fx:controller="org.jabref.gui.fieldeditors.LinkedFilesEditor">
-    <ListView fx:id="listView" prefHeight="0" HBox.hgrow="ALWAYS" maxHeight="100" />
+    <ListView fx:id="listView" HBox.hgrow="ALWAYS"/>
     <Button onAction="#addNewFile"
             styleClass="icon-button">
         <graphic>
diff --git a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java
index b0efcf387cb..d8446a7e47b 100644
--- a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java
+++ b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java
@@ -236,7 +236,16 @@ public Parent getNode() {
 
     @FXML
     private void addNewFile() {
-        viewModel.addNewFile();
+//        System.out.println(listView.getPrefHeight());
+        int number = viewModel.addNewFile();
+        if(number < 3)
+            return;
+        else{
+            listView.setMinHeight(number*20);
+//            listView.setPrefHeight(number*5);
+            System.out.println(listView.getPrefHeight());
+        }
+//
     }
 
     @FXML
diff --git a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
index 4525c7f050c..ad821b01772 100644
--- a/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
+++ b/src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
@@ -135,7 +135,7 @@ public ListProperty<LinkedFileViewModel> filesProperty() {
         return files;
     }
 
-    public void addNewFile() {
+    public int addNewFile() {
         Path workingDirectory = databaseContext.getFirstExistingFileDir(preferences.getFilePreferences())
                                                .orElse(preferences.getFilePreferences().getWorkingDirectory());
 
@@ -155,6 +155,7 @@ public void addNewFile() {
                     preferences,
                     externalFileTypes));
         });
+        return files.size();
     }
 
     @Override