Set clippy warnings to fail the CI (#128)

* Set clippy warnings to fail the CI

* Modify RUSTFLAGS environment variable

* Remove unused comments

* Add missing clippy command-line argument

* Remove unnecessary map

* Fix failing build

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ on:
 
 env:
   CARGO_TERM_COLOR: always
-  RUSTFLAGS: -Dwarnings
+  RUSTFLAGS: "-D warnings -C opt-level=0"
 
 jobs:
 
@@ -19,4 +19,4 @@ jobs:
   build:
     name: Run build
     uses: ./.github/workflows/run-build.yml
-
+

.github/workflows/run-build.yml

@@ -3,11 +3,6 @@ name: Run Build
 on:
   workflow_call:
 
-# since opt-level of 3 is used for dependencies in dev profile as
-# configured through Cargo.toml, we explicitly set it to 0
-env:
-  RUSTFLAGS: "-C opt-level=0"
-
 jobs:
   build:
     strategy:

.github/workflows/run-tests.yml

@@ -3,11 +3,6 @@ name: Run Tests and Linters
 on:
   workflow_call:
 
-# since opt-level of 3 is used for dependencies in dev profile as
-# configured through Cargo.toml, we explicitly set it to 0
-env:
-  RUSTFLAGS: "-C opt-level=0"
-
 jobs:
   fmt:
     name: Run rustfmt in check mode
@@ -54,6 +49,7 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
             command: clippy
+            args: -- -D warnings
 
   spell-check:
     name: Run spell check

src/gui/tabs/statistics_tab/mini_widgets.rs

@@ -141,10 +141,7 @@ pub fn genre_stats(series_infos: Vec<&SeriesMainInformation>) -> Element<'_, Mes
         })
     });
 
-    let mut genre_count: Vec<(Genre, usize)> = genre_count
-        .into_iter()
-        .map(|(genre, count)| (genre, count))
-        .collect();
+    let mut genre_count: Vec<(Genre, usize)> = genre_count.into_iter().collect();
 
     genre_count.sort_unstable_by(|a, b| b.1.cmp(&a.1));